[Memhammer] Meta Schedule Rules #7

jinhongyii · 2022-01-10T07:24:04Z

Migrated from tlc-pack repo

[Meta Schedule][M3c] Schedule Rules, Mutator & Postprocs (apache#485) [Meta Schedule][M3c] PostOrderApply (apache#486) Fix Post Order Apply (apache#490) [MetaSchedule] Relay Integration (apache#489) [M3c][Meta Schedule] Add Trace Correctness Test for PostOrderApply (apache#492) Fix replay trace. (apache#493) [M3c][Meta Schedule] Implement the Replay Func class. (apache#495) [PR] Test script for meta-schedule task extraction. Interface to load… (apache#494) [Meta Schedule Refactor] Get child blocks (apache#500) Read-at && Write-at (apache#497) [M3c][Meta Schedule] Measure Callbacks (apache#498) [Bug] Fix Infinite Loop Caused When Calling Methods Not Overrided In PyClass (apache#496) [MetaSchedule] Sample-Perfect-Tile (apache#501) [MetaSchedule] TE Workloads (apache#502) [TensorIR] GetProducer, GetConsumer (apache#506) [MetaScheduleRefactor] Annotate&Unannotate (apache#505) [MetaSchedule] Multi-Level-Tiling & Auto-Inline (apache#503) [Tests] Add unittests for auto-inline and multi-level-tiling (apache#508) [Meta Schedule] Minor Fixes (apache#507) [MetaSchedule] Rewrite Cooperative-Fetching / Unbound-Block / Reduction-Block (apache#509) [MetaSchedule] Rewrite Parallel-Vectorize-Unroll / Verify-GPU / Disallow-Dynamic-Loops (apache#499) [Meta Schedule] Add Helper Function & Minor Modification (apache#512) [MetaSchedule] Test for Rewrite Parallel-Vectorize-Unroll (apache#513) [Meta Schedule] Feature Extractor & Cost Model (apache#510) Blockize & Tensorize (apache#514) Layout Rewriting: Suggest-Index-Map (apache#520) [MetaSchedule] Parallel-Vectorize-Unroll & Random-Compute-Location (apache#516) [Meta Schedule] Per-Store-Feature (apache#521) Add traced schedule for blockize & tensorize (apache#526) [Meta Schedule] Add XGBoost Model & Random Model (apache#519) User-Interface: Tune-TIR (apache#525) User-Interface: Tune-TE (apache#527) [Minor] More logging on python (apache#528) Get CUDA tuning working (apache#529) [MetaSchedule] TensorRT BYOC (apache#518) [BugFix] LocalBuilder API (apache#531) [Meta Schedule] Add Cost Model Update Measure Callback (apache#530) [Bugfix] BuilderInput with default params (apache#532) [MetaSchedule] Mutator-Tile-Size, Mutate-Parallel, Mutate-Unroll (apache#534) [Meta Schedule] Evolutionary Search (apache#522) [BugFix] Remove duplicated definition of MakeMultinomialSampler (apache#535) [Meta Schedule] Fix some bugs (apache#537) Initiate Experiments for CPU Performance Alignment with Ansor (apache#538) [Meta Schedule] Tweak experiment scripts (apache#539) [Meta Schedule] Initiate experiments on CUDA (apache#540) [TIR][Schedule] Buffer transform (apache#523) Auto Tensor Core (apache#524) Working on Evo Search (apache#542) [Meta Schedule] Add Replay Tuning Interface (apache#543) Evolutionary Search on CPU (apache#544) Misc improvement over the error message (apache#545) [TIR][Schedule] Software pipelining (apache#533) [Meta Schedule Refactor] fixing unit tests (apache#547) [MetaSchedule] Mutator-Compute-Location (apache#548) Misc Improvement of Evolutionary Search (apache#549) Hotfix for software pipeline (apache#552) Misc Improvement (apache#550) [Cherry-Pick][TensorIR] Primitive "SetScope" (apache#9738) (apache#555) Rule RFactor (apache#551) [MemHammer] Rewrite Rules (apache#554) [MetaSchedule] Schedule Rule: Cross-Thread Reduction (apache#556) [MetaSchedule] Performance Alignment - NRM and SFM (CUDA) (apache#559) [MetaSchedule] Perf Alignment - NRM on CUDA (apache#560) [TIR] Reorder the block iters of the blocks generated by RFactor (apache#561) Co-authored-by: Siyuan Feng <[email protected]> Co-authored-by: Bohan Hou <[email protected]> Co-authored-by: Hongyi Jin <[email protected]> Co-authored-by: Ruihang Lai <[email protected]> Co-authored-by: Junru Shao <[email protected]> Co-authored-by: Wuwei Lin <[email protected]> Co-authored-by: Sunghyun Park <[email protected]> Co-authored-by: Xiyou Zhou <[email protected]>

* format new auto padding algorithm address comment revert black address comment address comment format finally over rename auto padding tmp make gemm work minor auto padder + mutator (undone) * add new line * address comment

* minor change * revert

* meta schedule perf align: misc improvement for search space * fix unittest * remove a log(info) * code review * update member name * init_max_fail_count to init_min_unmeasured Co-authored-by: Junru Shao <[email protected]>

vinx13 · 2022-01-13T01:28:35Z

src/tir/schedule/primitive/read_write_at.cc

    StmtSRef result_block_sref =
        impl.ReplaceScopeBlock(new_loop_block.first.get(), new_loop_block.second->block.get());
-    impl.UpdateBlockInfo(result_block_sref);
+    impl.UpdateBlockInfo(result_block_sref, !new_loop_block.second->iter_values.empty());


why is affine_binding == !iter_values.empty()?

vinx13 · 2022-01-13T01:30:25Z

src/arith/iter_affine_map.cc

    PrimExpr expected_extra_base = 0;
    PrimExpr expected_scale = base_scale.value();
    for (size_t i = 0; i < expr->args.size();) {
+      if (is_one(expr->args[i]->source->extent)) {


can we have some test cases for iter map?

vinx13 · 2022-01-13T20:28:07Z

src/meta_schedule/schedule_rule/analysis.cc

+  return false;
+}
+
+void FallbackRule(const For& loop, Array<Integer>* stage, Array<Integer>* order) {


Suggested change

void FallbackRule(const For& loop, Array<Integer>* stage, Array<Integer>* order) {

void FallbackSoftwarPipelineRule(const For& loop, Array<Integer>* stage, Array<Integer>* order) {

vinx13 · 2022-01-13T20:36:46Z

src/meta_schedule/schedule_rule/analysis.h

+/*!
+ * \brief whether the loop's body has the pattern: 2 cache read shared followed by a nested
+ * software pipeline
+ * \param the loop


Suggested change

* \param the loop

* \param loop the loop

vinx13 · 2022-01-13T21:51:04Z

src/meta_schedule/schedule_rule/multi_level_tiling_memhammer.cc

+    if (tir::IsCacheReadSharedPattern(loop)) {
+      stage = {0, 0, 0, 0, 0, 1, 1};
+      order = {0, 3, 1, 4, 5, 2, 6};


I'd prefer doing it with at least some basic analysis

vinx13 · 2022-02-16T21:32:04Z

@jinhongyii can you rebase and let's get this in

junrushao · 2022-06-01T05:28:03Z

I'm going to close this PR given it looks like it's been stale for a while. @jinhongyii @vinx13

* Shape and type deduction. * Fix header. * Add call attrs to the deduce signature. * Address comments. * Add DiagnosticContext to IRBuilder and inference signature. * Fix nits.

* [IR] Introduce StructInfo * StructInfoFunctor and Analysis Support * [TVMScript] Parse type/shape annotation with StructInfo * remove runtime type assign * Remove type/shape during parsing (#2) * Normalizer prep: simple checks and legacy function renaming. * Struct info deduction in BlockBuilder. * Two TODOs * StructInfo Normalizer Fixes (#3) * StructInfo AST Fix * Fix Extern Func Deduction and shape mutator. * Update VoidStructInfo & globalvar (#4) * Fix passes and proper sinfo propagation. * Refactor EraseToWellDefined to Enable Remapping * [WIP] First stab at symbolic param tracking * Update EraseToWellDefined to support symbolic shape return (#5) * fix R.shape with ndim (#6) * Remove update shape/type * Address review comment, AnnotateTypeShape=>AnnotateStructInfo * Update include/tvm/script/ir_builder/relax/frame.h Co-authored-by: Ruihang Lai <[email protected]> * Address comments * Update printer to use structinfo (#7) * Update Error mechanism to prep for obj loc based reporting * Symbolic shape aware function call return value derivation. The main flow works as follows: - Match and populate shape_var_map and var_map by visit each pair of param and call arguments. - Call EraseToWellDefined to map the ret parameter to new result. * [ANALYSIS] Refactor well-form to only look at struct info. * Update comments according to reviews. * Update include/tvm/relax/struct_info.h Co-authored-by: Ruihang Lai <[email protected]> Co-authored-by: Siyuan Feng <[email protected]> Co-authored-by: Tianqi Chen <tqchen> Co-authored-by: Ruihang Lai <[email protected]>

spectrometerHBH and others added 14 commits December 30, 2021 01:06

Removing 2 unit tests for software pipelining (apache#562)

f8fc975

[MemHammer] Lower Pass + Unittests (apache#557)

ee94a73

* format new auto padding algorithm address comment revert black address comment address comment format finally over rename auto padding tmp make gemm work minor auto padder + mutator (undone) * add new line * address comment

Perf Align: Remove Auto-inline before Multi-level-tiling (apache#564)

7474fb4

* minor change * revert

Fix Sketch Generation Unittests (apache#565)

b0fb8af

speed up VerifyGpuCode (apache#568)

a81e440

[Performance Align] fixing codegen problems (apache#569)

e16003a

[Meta schedule] improve search space (#1)

c2f8106

* meta schedule perf align: misc improvement for search space * fix unittest * remove a log(info) * code review * update member name * init_max_fail_count to init_min_unmeasured Co-authored-by: Junru Shao <[email protected]>

Hot fix for bound predicate (apache#3)

0f3892b

[Meta Schedule] Update Tune Relay (apache#4)

3d8c570

[Performance Align] fixing codegen problems (apache#5)

b138d63

memhammer part3

64601b9

fix comment

58aaba1

format

ed8c5cb

jinhongyii requested review from Hzfengsy, junrushao and vinx13 as code owners January 10, 2022 07:24

vinx13 reviewed Jan 13, 2022

View reviewed changes

junrushao force-pushed the meta-schedule branch from 494101d to 3c6882a Compare January 27, 2022 06:42

junrushao force-pushed the meta-schedule branch 6 times, most recently from fd5719a to 88cf664 Compare February 21, 2022 17:42

junrushao closed this Jun 1, 2022

junrushao added a commit that referenced this pull request Sep 21, 2022

Add tvm_wmma_set_element and tvm_wmma_get_element in cuda codegen (#7)

0385000

junrushao pushed a commit that referenced this pull request Oct 18, 2022

Shape and type deduction (#7)

7ccf467

* Shape and type deduction. * Fix header. * Add call attrs to the deduce signature. * Address comments. * Add DiagnosticContext to IRBuilder and inference signature. * Fix nits.

junrushao pushed a commit that referenced this pull request Feb 8, 2023

Shape and type deduction (#7)

32781ef

* Shape and type deduction. * Fix header. * Add call attrs to the deduce signature. * Address comments. * Add DiagnosticContext to IRBuilder and inference signature. * Fix nits.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Memhammer] Meta Schedule Rules #7

[Memhammer] Meta Schedule Rules #7

Uh oh!

jinhongyii commented Jan 10, 2022

Uh oh!

vinx13 Jan 13, 2022

Uh oh!

vinx13 Jan 13, 2022

Uh oh!

vinx13 Jan 13, 2022

Uh oh!

vinx13 Jan 13, 2022

Uh oh!

vinx13 Jan 13, 2022

Uh oh!

vinx13 commented Feb 16, 2022

Uh oh!

junrushao commented Jun 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	void FallbackRule(const For& loop, Array<Integer>* stage, Array<Integer>* order) {
	void FallbackSoftwarPipelineRule(const For& loop, Array<Integer>* stage, Array<Integer>* order) {

[Memhammer] Meta Schedule Rules #7

[Memhammer] Meta Schedule Rules #7

Uh oh!

Conversation

jinhongyii commented Jan 10, 2022

Uh oh!

vinx13 Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

vinx13 Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

vinx13 Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

vinx13 Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

vinx13 Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

vinx13 commented Feb 16, 2022

Uh oh!

junrushao commented Jun 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants