Skip to content

Commit

Permalink
Add TODOs for validation handling within Jupiter TestEngine
Browse files Browse the repository at this point in the history
Issue: #242
  • Loading branch information
sbrannen committed Mar 23, 2017
1 parent f03cc6d commit 7aab5eb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ protected static <E extends AnnotatedElement> String determineDisplayName(E elem
Optional<DisplayName> displayNameAnnotation = findAnnotation(element, DisplayName.class);
if (displayNameAnnotation.isPresent()) {
String displayName = displayNameAnnotation.get().value().trim();
// TODO Replace logging with precondition check once we have a proper mechanism for
// TODO [#242] Replace logging with precondition check once we have a proper mechanism for
// handling exceptions during the TestEngine discovery phase. Otherwise, the entire
// TestEngine dies without executing anything.
//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ private RepeatedTestDisplayNameFormatter displayNameFormatter(RepeatedTest repea

String pattern = repeatedTest.name().trim();

// TODO Replace logging with precondition check once we have a proper mechanism for
// TODO [#242] Replace logging with precondition check once we have a proper mechanism for
// handling exceptions during the TestEngine discovery phase.
//
// Preconditions.notBlank(name, () -> String.format(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ private ParameterizedTestNameFormatter createNameFormatter(Method templateMethod
ParameterizedTest parameterizedTest = findAnnotation(templateMethod, ParameterizedTest.class).get();
String name = parameterizedTest.name().trim();

// TODO Replace logging with precondition check once we have a proper mechanism for
// TODO [#242] Replace logging with precondition check once we have a proper mechanism for
// handling exceptions during the TestEngine discovery phase.
//
// Preconditions.notBlank(name, () -> String.format(
Expand Down

0 comments on commit 7aab5eb

Please sign in to comment.