Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'java' from junit5-jupiter-starter-maven-kotlin #104

Closed
2 tasks
sormuras opened this issue May 27, 2019 · 4 comments
Closed
2 tasks

Remove 'java' from junit5-jupiter-starter-maven-kotlin #104

sormuras opened this issue May 27, 2019 · 4 comments

Comments

@sormuras
Copy link
Member

sormuras commented May 27, 2019

It should, like the junit5-jupiter-starter-gradle-kotlin project, only contain the following directories:

Main

  • src/main/kotlin
  • src/test/kotlin

Deliverables

  • Remove java from junit5-jupiter-starter-maven-kotlin sample project.
  • Trim pom.xml down to the minimum of configurations needed to get Maven + Kotlin + Jupiter happy.
@marcphilipp
Copy link
Member

I think the whole point was to have a mixed Java/Kotlin project, wasn‘t it?

@sormuras
Copy link
Member Author

Yes. I should have directed it to be what is now described in #105 -- a Java/Kotlin JUnit 4/5 mash up using Maven, it has all a "junit-migration-..." sample project needs.

A junit5-jupiter-starter-... should only use the bare minimum to get started with Jupiter a the selected build tool and language.

@marcphilipp
Copy link
Member

Ah, ok, that makes sense. 👍

daggerok added a commit to daggerok/fork-junit5-samples that referenced this issue May 28, 2019
daggerok added a commit to daggerok/fork-junit5-samples that referenced this issue May 28, 2019
@daggerok
Copy link
Contributor

Hello,

please review #106


Regards,
Maksim

daggerok added a commit to daggerok/fork-junit5-samples that referenced this issue May 28, 2019
daggerok added a commit to daggerok/fork-junit5-samples that referenced this issue May 28, 2019
…Trim pom.xml down to the minimum of configurations needed to get Maven + Kotlin + Jupiter happy. Update readme accordingly. junit-team#104
daggerok added a commit to daggerok/fork-junit5-samples that referenced this issue May 28, 2019
…Trim pom.xml down to the minimum of configurations needed to get Maven + Kotlin + Jupiter happy. Update readme accordingly. Reformat kotlin classes with tabs instead of spaces. junit-team#104
daggerok added a commit to daggerok/fork-junit5-samples that referenced this issue May 28, 2019
…Trim pom.xml down to the minimum of configurations needed to get Maven + Kotlin + Jupiter happy. Update readme accordingly. Reformat kotlin classes with tabs instead of spaces. junit-team#104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants