handle the {index} parameter like a native MessageFormat argument. #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example that allows to specified leading zero by using
{index,number,0000}
| String finalPattern = pattern.replaceAll("\\{index\\}", | ||
| Integer.toString(index)); | ||
| String finalPattern = pattern; | ||
| Pattern indexMatcherPattern = Pattern.compile("(\\{)index([^\\}]*\\})"); |
There was a problem hiding this comment.
Could you extract a constant for this Pattern?
|
Please add some tests for this. |
| Pattern indexMatcherPattern = Pattern.compile("(\\{)index([^\\}]*\\})"); | ||
| Matcher matcher = indexMatcherPattern.matcher(pattern); | ||
| if (matcher.find()) { | ||
| String idxPattern = matcher.group(1) + 0 + matcher.group(2); |
There was a problem hiding this comment.
Please use "0" instead of 0, because it is clearer.
added 3 commits
July 31, 2014 23:53
* extract a constant for this Pattern * use while loop (replace and not replaceall) * use "0" instead of 0
| @@ -163,6 +165,8 @@ | |||
| * @since 4.0 | |||
| */ | |||
| public class Parameterized extends Suite { | |||
| private static final String INDEX_MATCHER_PATTERN = "(\\{)index([^\\}]*\\})"; | |||
There was a problem hiding this comment.
I meant create a constant for the Pattern. Compiling a pattern isn't cheap
|
Looks like an interesting addition. This also requires adjusting the documentation. I would suggest adding an extra paragraph (after line 75 in the changed file) giving a number of insightful and compelling examples on how to make good use of this new feature. |
|
Should the conflicts be fixed, or maybe it's too late and we should just close this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example that allows to specified leading zero by using
{index,number,0000}