Now tests with assumption violations are flagged with 'I' #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbirkner
approved these changes
May 31, 2018
kcooney
reviewed
Jun 1, 2018
| @@ -137,7 +137,7 @@ public void testIgnored(Description description) throws Exception { | |||
|
|
|||
| @Override | |||
| public void testAssumptionFailure(Failure failure) { | |||
| // do nothing: same as passing (for 4.5; may change in 4.6) | |||
| ignoreCount.getAndIncrement(); | |||
There was a problem hiding this comment.
In #1294 (currently targeted for 4.13) we are proposing updating this class to collect assumption failure counts, so I am not sure we should make this change.
There was a problem hiding this comment.
Oh great! in my opinion add a counter for the assumption failures would be great in order to know exactly how many did the test have
Tibor17
reviewed
Nov 15, 2018
| @@ -137,7 +137,7 @@ public void testIgnored(Description description) throws Exception { | |||
|
|
|||
| @Override | |||
| public void testAssumptionFailure(Failure failure) { | |||
| ignoreCount.getAndIncrement(); | |||
| // do nothing: same as passing (for 4.5; may change in 4.6) | |||
There was a problem hiding this comment.
This is absolutely wrong. We rely on it!
You cannot remove the line. There is no field counter for assumptions and even if it was there, it is a change in behavior in all other frameworks and their integration tests will fail.
There was a problem hiding this comment.
@Tibor17 I suggest commenting on the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #1525 now the tests that has assumption violations are flagged with 'I' in the textUI output