-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add note about duplicate test execution with @Suite #5080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mpkorstanje
merged 19 commits into
main
from
rien/junit-platform-suite-engine-documentation
Oct 31, 2025
Merged
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
16ff13b
Add note duplicate test execution with @Suite
mpkorstanje c0a8776
Update pointers and commands in readme
mpkorstanje 8546b97
Extract and update note to independent section
mpkorstanje 6f2dacd
Update Suite annotation to match
mpkorstanje f74202e
Update Suite annotation to match
mpkorstanje 36365a3
Merge remote-tracking branch 'origin/main' into rien/junit-platform-s…
mpkorstanje 890a5b7
Update documentation/src/docs/asciidoc/user-guide/advanced-topics/jun…
mpkorstanje c3a88d0
Draft diagrams
mpkorstanje fcd8f7e
Rework, rewrite, revise
mpkorstanje 5e02295
Remove ellipsis, spell Jupiter correctly
mpkorstanje b822014
Rework, rewrite, revise
mpkorstanje 4df8e81
Rename diagrams to match header ids
mpkorstanje aa2d097
Update documentation/src/docs/asciidoc/user-guide/advanced-topics/jun…
mpkorstanje bef798d
Update documentation/src/docs/asciidoc/user-guide/advanced-topics/jun…
mpkorstanje ed4a741
Update documentation/src/plantuml/launcher-api-diagram.puml
mpkorstanje 05fb4fd
Update documentation/src/docs/asciidoc/user-guide/advanced-topics/lau…
mpkorstanje c132c99
Update documentation/src/docs/asciidoc/user-guide/advanced-topics/jun…
mpkorstanje 970d710
Update junit-platform-suite-api/src/main/java/org/junit/platform/suit…
mpkorstanje da41307
Merge paragraphs
mpkorstanje File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add sth. like the following?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is time to add a drawing or two. I'll come back to that. Something along the lines of:
https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-junit-platform-engine#suites-with-different-configurations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mpkorstanje Do you have time to add the drawing for 6.0.1 or should we move this PR to 6.1.0-M1?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved it to 6.1.0-M1. We don't have to rush this one. It's not a bug.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.