Skip over unavailable resources in ConcurrentHierarchicalTestExecutorService #5078
+171
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
changed the title
6 tasks
mpkorstanje
force-pushed
the
rien/parallel-execution-custom-implementation
branch
from
64322a7 to
452ebbc
Compare
Base automatically changed from
rien/parallel-execution-custom-implementation-reverse-stealing-order
to
marc/parallel-execution-custom-implementation
October 24, 2025 14:29
marcphilipp
force-pushed
the
rien/parallel-execution-custom-implementation
branch
from
e81d757 to
82fa0c6
Compare
marcphilipp
reviewed
Oct 24, 2025
Comment on lines
-533
to
-534
| private final EntryOrdering ordering = new EntryOrdering(); | ||
| private final Queue<Entry> queue = new PriorityBlockingQueue<>(); |
There was a problem hiding this comment.
Looks like I forgot to use the custom comparator... 😳
Comment on lines
+247
to
+248
| // One entry at a time to avoid blocking too much | ||
| tryToStealWork(entriesRequiringResourceLocks.get(0), BlockingMode.BLOCKING); |
There was a problem hiding this comment.
Could you please elaborate on this? Is there evidence this is better than doing all of them?
marcphilipp
force-pushed
the
rien/parallel-execution-custom-implementation
branch
from
82fa0c6 to
63ace09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5076.
I hereby agree to the terms of the JUnit Contributor License Agreement.