[openrewrite] add SanityCheck featuring tech.picnic.errorprone.refasterrules#5003
Closed
Pankraz76 wants to merge 1 commit intojunit-team:mainfrom
Closed
[openrewrite] add SanityCheck featuring tech.picnic.errorprone.refasterrules#5003Pankraz76 wants to merge 1 commit intojunit-team:mainfrom
SanityCheck featuring tech.picnic.errorprone.refasterrules#5003Pankraz76 wants to merge 1 commit intojunit-team:mainfrom
Conversation
Pankraz76
changed the title
SanityCheck featuring CommonStaticAnalysisSanityCheck featuring tech.picnic.errorprone.refasterrules
Pankraz76
force-pushed
the
add-SanityCheck
branch
from
bf09a7c to
dc7e4fb
Compare
Pankraz76
commented
Sep 27, 2025
Contributor
Author
Pankraz76
left a comment
Pankraz76
left a comment
There was a problem hiding this comment.
kindly request feedback. Thanks.
gradle/rewrite.gradle
Outdated
|
|
||
| rewrite { | ||
| activeRecipe("org.junit.jupiter.openrewrite.SanityCheck") | ||
| exclusions.addAll("**.ci-temp**") |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| exclusions.addAll("**.ci-temp**") |
| uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5.5.1 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| - name: rewriteDryRun |
Contributor
Author
There was a problem hiding this comment.
this is just an reminder of course you need to choose where to put this best.
| - tech.picnic.errorprone.refasterrules.PrimitiveRulesRecipes | ||
| - tech.picnic.errorprone.refasterrules.StreamRulesRecipes | ||
| - tech.picnic.errorprone.refasterrules.TimeRulesRecipes | ||
| # - org.openrewrite.staticanalysis.EqualsAvoidsNull |
Contributor
Author
There was a problem hiding this comment.
this does change alot despite the initial effort. Every tool has its benefits making it win to the community.
This was referenced Sep 28, 2025
Member
|
We have already decided against adopting OpenRewrite for our day-to-day build. I'd be open to looking at Error Prone's refaster with Picnic's rules, though, as discussed on the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotationsrelates to:
rewritesupport forerrorprone.refasterrules#5002SanityCheckfeaturingCommonStaticAnalysisdiffplug/spotless#2651