Skip to content

Replace opt-in annotation with extension method #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2024
Merged

Replace opt-in annotation with extension method #4062

merged 5 commits into from
Oct 11, 2024

Conversation

@marcphilipp
Copy link
Member

Overview

  • Replace annotation with boolean-returning method
  • Return enum instead of boolean
  • Create specialized sub-interface of Extension

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp
Replace annotation with boolean-returning method
1db2432
@marcphilipp
Return enum instead of boolean
6b80f42 
This avoids being able to opt out should the default be changed to
test-scoped.
@marcphilipp marcphilipp self-assigned this Oct 9, 2024
@marcphilipp marcphilipp force-pushed the marc/replace-annotation-with-extension-method branch from 3e49904 to ba6cd95 Compare October 9, 2024 08:13
@marcphilipp marcphilipp force-pushed the marc/replace-annotation-with-extension-method branch from ba6cd95 to 5acbdb6 Compare October 9, 2024 08:41
@marcphilipp marcphilipp marked this pull request as ready for review October 9, 2024 08:43
This was referenced Oct 9, 2024
Merged
Closed
@marcphilipp
Copy link
Member Author

@JojOatXGME I'd appreciate it if you could take a look!

@marcphilipp marcphilipp force-pushed the marc/replace-annotation-with-extension-method branch from 5acbdb6 to bef4874 Compare October 9, 2024 08:58
@marcphilipp
Create specialized sub-interface of Extension
bbafe10 
This enforces that only potentially affected extensions can override the
method determining the extension context scope during test class
instance construction.
@marcphilipp marcphilipp force-pushed the marc/replace-annotation-with-extension-method branch from bef4874 to bbafe10 Compare October 9, 2024 09:00
JojOatXGME
JojOatXGME approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@JojOatXGME JojOatXGME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I still kept a few comments to communicate what I was thinking while reading your PR.

@marcphilipp marcphilipp mentioned this pull request Oct 10, 2024
Merged
6 tasks
@marcphilipp marcphilipp enabled auto-merge (rebase) October 11, 2024 13:00
@marcphilipp marcphilipp disabled auto-merge October 11, 2024 13:01
@marcphilipp marcphilipp merged commit e3c5383 into main Oct 11, 2024
15 checks passed
@marcphilipp marcphilipp deleted the marc/replace-annotation-with-extension-method branch October 11, 2024 13:58
@marcphilipp marcphilipp added this to the 5.12 M1 milestone Oct 14, 2024
@marcphilipp marcphilipp linked an issue Oct 16, 2024 that may be closed by this pull request
Allow all extensions to access method-level extension context #4057
Closed
9 tasks
@marcphilipp marcphilipp removed a link to an issue Oct 16, 2024
Allow all extensions to access method-level extension context #4057
Closed
9 tasks
@sbrannen sbrannen mentioned this pull request Oct 22, 2025
Closed
2 tasks
@sbrannen sbrannen mentioned this pull request Oct 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JojOatXGME JojOatXGME JojOatXGME approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marcphilipp marcphilipp

Labels

component: Jupiter theme: extensions type: enhancement

Projects

Sovereign Tech Fund
Status: Done

Milestone

5.12.0-M1

Development

Successfully merging this pull request may close these issues.

3 participants

@marcphilipp @JojOatXGME