Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unnecessary "tabs" permission #4

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

djcrock
Copy link
Contributor

@djcrock djcrock commented Sep 7, 2020

Currently, when installing the extension from the Chrome web store, the user is notified that the extension can Read your browsing history.

image

According to the docs, this is because the tabs permission is requested. However, the tabs permission is only required if any of the following attributes of the tab object are needed:

  • url
  • pendingUrl
  • title
  • favIconUrl

Per the docs, the tabs permission (emphasis mine):

Gives your extension access to privileged fields of the Tab objects used by several APIs including chrome.tabs and chrome.windows. In many circumstances your extension will not need to declare the "tabs" permission to make use of these APIs.

This extension does not use any of these properties, so it can use the chrome.tabs API without requesting the tabs permission. Removing this permission request will give users more confidence that the extension is secure and safe to use, since they will no longer be notified that it can read their browsing history.

@juni-vogt juni-vogt merged commit b122c54 into juni-vogt:master Sep 15, 2020
@juni-vogt
Copy link
Owner

Thank you very much for this and the elaborate explanation! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants