Repository navigation
fix(report): stop LLM title clustering from over-merging unrelated sessions #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new overlap coefficient, any title that reduces to a single significant token gets a perfect score against every longer title containing that token, so a generic summary like
Fix API/APIwill cluster with unrelatedAdd API auth,Update API billing, etc. This regresses the over-merge behavior for apple-fm/non-LLM grouping because the previous Jaccard/shared-token rule would not merge on just one shared token; singleton titles need a stricter rule such as requiring at least two significant shared tokens.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 715c070.
tokens_overlapnow requires at least two shared significant tokens when the smaller token set has only one token (if smaller <= 1 { return shared >= 2; }), before applying the overlap coefficient. This prevents a singleton title ("API"/"Fix API") from merging with every unrelated longer title containing that token, restoring the stricter behavior for apple-fm/non-LLM grouping while keeping genuine multi-token near-duplicates clustering. Regression tests added (tokens_overlap_singleton_does_not_overcluster,cluster_titles_does_not_overcluster_singletons). cargo test + clippy green.