fix(tui): align scrollbar position with viewport - #694
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
1 issue found
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
astkaasa
force-pushed
the
fix/tui-scrollbar-position
branch
from
June 8, 2026 23:24
7624878 to
52ee94a
Compare
Contributor
Author
junhoyeo
approved these changes
Jun 9, 2026
junhoyeo
left a comment
Owner
There was a problem hiding this comment.
Reviewed: scrollbar rescaling math verified against ratatui 0.29 part_lengths(); all 8 ScrollbarState call sites consistent; cargo check/clippy/tests (709 passed incl. 5 new scrollbar tests) verified locally. Merging.
Owner
|
@astkaasa cool, thanks a lot! |
t1000040
pushed a commit
to tmobi-internal/tokscale
that referenced
this pull request
Jun 30, 2026
Co-authored-by: astkaasa <2796928+astkaasa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Tests
cargo test -p tokscale-cli scrollbar_statecargo test -p tokscale-cli test_overview_scroll_keeps_rendered_capacity_after_resizecargo test -p tokscale-cliSummary by cubic
Fixes TUI scrollbars so the thumb matches the visible viewport across all screens and edge cases. The thumb now reaches the end of the track on the last page and stays at zero on single-page lists.
ratatuicontent positions, set viewport content length, and clamp overscroll using wide math for large lists.Written for commit 52ee94a. Summary will update on new commits.