fix(antigravity): include cache rows in default submit - #653
Merged
IvGolovach merged 1 commit intoJun 4, 2026
Merged
Conversation
Validation * Validation tier: Tier 2 — Narrow runtime change, core client registry flag changes submit default selection and targeted tests cover Antigravity parsing/submit graph behavior. * Red: `cargo test -p tokscale-core antigravity`: FAILED before implementation with `test_antigravity_submit_default_is_true` and `test_submit_default_graph_includes_antigravity_cache_rows`. * `cargo test -p tokscale-core antigravity`: PASS, 14 passed. * `cargo test -p tokscale-cli default_submit_clients`: PASS, 2 passed. * `cargo fmt --all -- --check`: PASS. * `cargo clippy -p tokscale-core --all-features -- -D warnings`: PASS. * `git diff --check`: PASS. * `git diff --cached --check`: PASS. * `bash scripts/check-version-coherence.sh`: PASS, Version coherence OK: 3.0.0. * Ledger: not applicable — scripts/ledger is absent and no ledger policy applies to this change family. * Version: PASS, `bash scripts/check-version-coherence.sh`; no version bump required because release workflow owns manifest version bumps. * Not run: frontend tests — not required because current frontend registry already accepts every core client id and no frontend files changed. * Not run: full workspace test suite — not required for selected validation tier. Rollback * git revert HEAD
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Antigravity was parseable locally but still excluded from the default submit path, so users could see Antigravity data in local reports while
tokscale submitsilently omitted it unless they explicitly selected the client. This change closes that end-to-end gap: Antigravity rows now participate in default submit totals, while unknown placeholder model IDs remain honest and visible until there is reliable evidence for canonical pricing aliases.Diff scope
crates/tokscale-core/src/clients.rs: flipsClientId::Antigravitytosubmit_default: trueand updates the client registry test.crates/tokscale-core/src/lib.rs: adds a submit-shaped graph regression that builds the same default client list and verifies Antigravity cache rows flow into graph totals.crates/tokscale-core/src/sessions/antigravity.rs: adds parser coverage showing unmapped placeholder models are preserved withantigravityprovider attribution.crates/tokscale-core/src/pricing/aliases.rs: documents the current no-alias behavior formodel_placeholder_m84andmodel_placeholder_m16with tests, avoiding speculative pricing mappings.Branch integrity
main.a86e688d620939d2c973c6d5625baa815ea223d7.0 behind / 1 aheadagainstorigin/main.a86e688d620939d2c973c6d5625baa815ea223d7.origin/mainis an ancestor of this branch.Commit integrity
d2ba22d7c1a6df272c0b7d1aa67af9870965dfff fix(antigravity): include cache rows in default submit.scripts/ledgeris absent and no ledger policy applies to this change family.Diff hygiene
git diff --name-status origin/main...HEAD: only Antigravity/core parser, client registry, pricing alias tests, and submit-shaped graph regression files changed.git diff --check origin/main...HEAD: PASS, no output.Validation mode and proof
Mode 2 - narrow runtime change, because the diff changes core client default selection and targeted parser/submit graph behavior without touching frontend, migrations, auth, or deployment tooling.
cargo test -p tokscale-core antigravityfailed before the implementation withtest_antigravity_submit_default_is_trueandtest_submit_default_graph_includes_antigravity_cache_rows.cargo test -p tokscale-core antigravity: PASS, 14 tests.cargo test -p tokscale-cli default_submit_clients: PASS, 2 tests.cargo fmt --all -- --check: PASS, no output.cargo clippy -p tokscale-core --all-features -- -D warnings: PASS.bash scripts/check-version-coherence.sh: PASS,Version coherence OK: 3.0.0.git diff --check origin/main...HEAD: PASS, no output.Required remote gates
Pending - GitHub Actions and mergeability checks will run after the PR is opened.
Migration notes
Not applicable - no database migration changed.
Runtime safety
The change only adds an already-parseable local client to default submit selection. It does not alter token parsing semantics for existing clients, does not fabricate placeholder model aliases, and keeps unknown Antigravity placeholders visible with zero priced cost until a real canonical mapping exists. No invariant regression introduced.
Documentation integrity
Not applicable - no documented commands or runbooks changed.
Rollback plan
Rollback: revert this PR. DB downgrade: not applicable. Data repair: not applicable. Operational caveats: reverting would make Antigravity local rows disappear from default submit totals again unless users explicitly submit that client.
Known residual risks
Remote CI and GitHub mergeability are pending until the PR is opened.
model_placeholder_m84andmodel_placeholder_m16intentionally remain unmapped because there is no safe canonical model evidence in repo history or public code search; their tokens will be included, but pricing can remain zero until a verified alias is added.Summary by cubic
Include
antigravitycache rows in the default submit path so they appear intokscale submittotals. Unmapped Antigravity placeholder models remain visible and unaliased.ClientId::Antigravitytosubmit_default: trueand updated the registry test.model_placeholder_m84,model_placeholder_m16) asantigravityrows and added alias tests confirming no mapping.Written for commit d2ba22d. Summary will update on new commits.