Skip to content

fix(antigravity): include cache rows in default submit - #653

Merged
IvGolovach merged 1 commit into
junhoyeo:mainfrom
IvGolovach:codex/antigravity-submit-e2e-20260601
Jun 4, 2026
Merged

fix(antigravity): include cache rows in default submit#653
IvGolovach merged 1 commit into
junhoyeo:mainfrom
IvGolovach:codex/antigravity-submit-e2e-20260601

Conversation

@IvGolovach

@IvGolovach IvGolovach commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Include Antigravity cache rows in the default submit client set now that the local parser and frontend source registry support the client.
  • Add a submit-shaped graph regression proving Antigravity cache rows are included when the CLI builds the default submit client list.
  • Preserve unmapped Antigravity placeholder models as visible Antigravity rows instead of inventing unsafe model aliases.

Why

Antigravity was parseable locally but still excluded from the default submit path, so users could see Antigravity data in local reports while tokscale submit silently omitted it unless they explicitly selected the client. This change closes that end-to-end gap: Antigravity rows now participate in default submit totals, while unknown placeholder model IDs remain honest and visible until there is reliable evidence for canonical pricing aliases.

Diff scope

  • crates/tokscale-core/src/clients.rs: flips ClientId::Antigravity to submit_default: true and updates the client registry test.
  • crates/tokscale-core/src/lib.rs: adds a submit-shaped graph regression that builds the same default client list and verifies Antigravity cache rows flow into graph totals.
  • crates/tokscale-core/src/sessions/antigravity.rs: adds parser coverage showing unmapped placeholder models are preserved with antigravity provider attribution.
  • crates/tokscale-core/src/pricing/aliases.rs: documents the current no-alias behavior for model_placeholder_m84 and model_placeholder_m16 with tests, avoiding speculative pricing mappings.

Branch integrity

  • Base branch: main.
  • Validated base SHA: a86e688d620939d2c973c6d5625baa815ea223d7.
  • Ahead/behind: 0 behind / 1 ahead against origin/main.
  • Merge base: a86e688d620939d2c973c6d5625baa815ea223d7.
  • Fast-forward safety: origin/main is an ancestor of this branch.

Commit integrity

  • Introduced commit: d2ba22d7c1a6df272c0b7d1aa67af9870965dfff fix(antigravity): include cache rows in default submit.
  • The PR contains one logical change scoped to Antigravity default-submit inclusion and its regression coverage.
  • Ledger: not applicable - scripts/ledger is absent and no ledger policy applies to this change family.
  • Version: not applicable - no manifest version bump is required because release workflow owns package version updates.

Diff hygiene

  • git diff --name-status origin/main...HEAD: only Antigravity/core parser, client registry, pricing alias tests, and submit-shaped graph regression files changed.
  • git diff --check origin/main...HEAD: PASS, no output.

Validation mode and proof

Mode 2 - narrow runtime change, because the diff changes core client default selection and targeted parser/submit graph behavior without touching frontend, migrations, auth, or deployment tooling.

  • TDD red proof: cargo test -p tokscale-core antigravity failed before the implementation with test_antigravity_submit_default_is_true and test_submit_default_graph_includes_antigravity_cache_rows.
  • cargo test -p tokscale-core antigravity: PASS, 14 tests.
  • cargo test -p tokscale-cli default_submit_clients: PASS, 2 tests.
  • cargo fmt --all -- --check: PASS, no output.
  • cargo clippy -p tokscale-core --all-features -- -D warnings: PASS.
  • bash scripts/check-version-coherence.sh: PASS, Version coherence OK: 3.0.0.
  • git diff --check origin/main...HEAD: PASS, no output.
  • Not run: frontend tests - not required because no frontend files changed and the current frontend registry already accepts core client IDs.
  • Not run: full workspace test suite - not required for selected validation mode; required remote CI will run after the PR is opened.

Required remote gates

Pending - GitHub Actions and mergeability checks will run after the PR is opened.

Migration notes

Not applicable - no database migration changed.

Runtime safety

The change only adds an already-parseable local client to default submit selection. It does not alter token parsing semantics for existing clients, does not fabricate placeholder model aliases, and keeps unknown Antigravity placeholders visible with zero priced cost until a real canonical mapping exists. No invariant regression introduced.

Documentation integrity

Not applicable - no documented commands or runbooks changed.

Rollback plan

Rollback: revert this PR. DB downgrade: not applicable. Data repair: not applicable. Operational caveats: reverting would make Antigravity local rows disappear from default submit totals again unless users explicitly submit that client.

Known residual risks

Remote CI and GitHub mergeability are pending until the PR is opened. model_placeholder_m84 and model_placeholder_m16 intentionally remain unmapped because there is no safe canonical model evidence in repo history or public code search; their tokens will be included, but pricing can remain zero until a verified alias is added.


Summary by cubic

Include antigravity cache rows in the default submit path so they appear in tokscale submit totals. Unmapped Antigravity placeholder models remain visible and unaliased.

  • Bug Fixes
    • Set ClientId::Antigravity to submit_default: true and updated the registry test.
    • Added a submit-shaped graph test to verify Antigravity cache rows are included in totals.
    • Preserved unmapped models (model_placeholder_m84, model_placeholder_m16) as antigravity rows and added alias tests confirming no mapping.

Written for commit d2ba22d. Summary will update on new commits.

Review in cubic

Validation
* Validation tier: Tier 2 — Narrow runtime change, core client registry flag changes submit default selection and targeted tests cover Antigravity parsing/submit graph behavior.
* Red: `cargo test -p tokscale-core antigravity`: FAILED before implementation with `test_antigravity_submit_default_is_true` and `test_submit_default_graph_includes_antigravity_cache_rows`.
* `cargo test -p tokscale-core antigravity`: PASS, 14 passed.
* `cargo test -p tokscale-cli default_submit_clients`: PASS, 2 passed.
* `cargo fmt --all -- --check`: PASS.
* `cargo clippy -p tokscale-core --all-features -- -D warnings`: PASS.
* `git diff --check`: PASS.
* `git diff --cached --check`: PASS.
* `bash scripts/check-version-coherence.sh`: PASS, Version coherence OK: 3.0.0.
* Ledger: not applicable — scripts/ledger is absent and no ledger policy applies to this change family.
* Version: PASS, `bash scripts/check-version-coherence.sh`; no version bump required because release workflow owns manifest version bumps.
* Not run: frontend tests — not required because current frontend registry already accepts every core client id and no frontend files changed.
* Not run: full workspace test suite — not required for selected validation tier.

Rollback
* git revert HEAD
@vercel

vercel Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
tokscale Ignored Ignored Preview Jun 1, 2026 4:01am

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@IvGolovach
IvGolovach merged commit b48af31 into junhoyeo:main Jun 4, 2026
15 checks passed
@IvGolovach
IvGolovach deleted the codex/antigravity-submit-e2e-20260601 branch June 4, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants