feat(leaderboard): show search on all periods and match displayName - #582
Merged
junhoyeo merged 1 commit intoMay 24, 2026
Merged
Conversation
…playName - Remove period === 'all' conditional that hid the search input - Remove search state reset when switching away from All Time tab - Update matchesLeaderboardSearch to match both username and displayName - Update All Time SQL WHERE clause to include displayName with COALESCE
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
junhoyeo
approved these changes
May 24, 2026
junhoyeo
left a comment
junhoyeo
left a comment
Owner
There was a problem hiding this comment.
LGTM — SQL is parameterized, UI sound. Follow-up: add a displayName-match unit test.
3 tasks
Owner
|
@leecoder this has been merged to v3.0.0: https://github.com/junhoyeo/tokscale/releases/tag/v3.0.0 thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show the leaderboard search field on all time periods (not just All Time) and extend search to match both
usernameanddisplayName.Changes
period === "all"conditional that hid the search input — search is now visible on All Time, This Month, This Week, and Custom periodsmatchesLeaderboardSearchto match bothusernameanddisplayNamefieldsLOWER(COALESCE(displayName, '')) LIKE ...alongside username matchingTesting
getLeaderboard.test.ts+getLeaderboardAllTime.test.ts)Summary by cubic
Enable leaderboard search on all periods and expand matching to both username and displayName. Search now persists when switching tabs.
usernameanddisplayNamein filtering, including All Time SQL viaCOALESCE(displayName, '').Written for commit 9b5f47f. Summary will update on new commits. Review in cubic