docs: add deno dx examples - #494
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
3 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="README.ko.md">
<violation number="1" location="README.ko.md:165">
P3: Added Deno `dx` quick-start without updating prerequisites to mention Deno.</violation>
</file>
<file name="README.md">
<violation number="1" location="README.md:166">
P3: The new `dx` quick-start path depends on Deno, but the prerequisites section doesn't mention Deno or the alias/version requirement.</violation>
</file>
<file name="README.ja.md">
<violation number="1" location="README.ja.md:165">
P3: Quickstart now advertises Deno `dx`, but prerequisites still omit Deno, so the setup guidance is inconsistent.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @@ -161,6 +161,9 @@ npx tokscale@latest | |||
| # 또는 bunx 사용 | |||
Contributor
There was a problem hiding this comment.
P3: Added Deno dx quick-start without updating prerequisites to mention Deno.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At README.ko.md, line 165:
<comment>Added Deno `dx` quick-start without updating prerequisites to mention Deno.</comment>
<file context>
@@ -161,6 +161,9 @@ npx tokscale@latest
bunx tokscale@latest
+# 또는 deno dx 사용
+dx tokscale@latest
+
# 라이트 모드 (테이블 렌더링만)
</file context>
| @@ -162,6 +162,9 @@ npx tokscale@latest | |||
| # Or use bunx | |||
Contributor
There was a problem hiding this comment.
P3: The new dx quick-start path depends on Deno, but the prerequisites section doesn't mention Deno or the alias/version requirement.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At README.md, line 166:
<comment>The new `dx` quick-start path depends on Deno, but the prerequisites section doesn't mention Deno or the alias/version requirement.</comment>
<file context>
@@ -162,6 +162,9 @@ npx tokscale@latest
bunx tokscale@latest
+# Or use deno dx
+dx tokscale@latest
+
# Light mode (table rendering only)
</file context>
| @@ -161,6 +161,9 @@ npx tokscale@latest | |||
| # またはbunxを使用 | |||
Contributor
There was a problem hiding this comment.
P3: Quickstart now advertises Deno dx, but prerequisites still omit Deno, so the setup guidance is inconsistent.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At README.ja.md, line 165:
<comment>Quickstart now advertises Deno `dx`, but prerequisites still omit Deno, so the setup guidance is inconsistent.</comment>
<file context>
@@ -161,6 +161,9 @@ npx tokscale@latest
bunx tokscale@latest
+# たはdeno dxを使用
+dx tokscale@latest
+
# ライトモード(テーブルレンダリングのみ)
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR introduces Deno DX running method that's got introduced in Deno v2.6
https://deno.com/blog/v2.6
Can confirm it works nicely, so I simply wanted to add a tiny note about this on README.
Summary by cubic
Add Deno v2.6 DX run option to the docs, showing
dx tokscale@latestas an alternative tonpxandbunxacross README files (EN, JA, KO, ZH-CN).Written for commit f4779eb. Summary will update on new commits.