fix: #2094

[LangLangBart]

Description

• fix /home/{user}/.fzf/shell/key-bindings.zsh:emulate:35: unknown argument -o #2094
• The 'emulate' command's ability to accept 'setopt' flags after the shell name is not available for
  Zsh versions below 5, causing an unwanted message when sourcing the file.
  • This issue was confirmed by @romkatv.
• Despite the original reporter claiming to have a more recent version of zsh, it's recommended they
  verify their version again. @fluency03

[romkatv]

• Despite the original reporter claiming to have a more recent version of zsh, it's recommended they
  verify their version again. @fluency03

The bulletproof way to verify this would be to add typeset -p ZSH_VERSION directly to /home/{my-user-name}/.fzf/shell/key-bindings.zsh, preferably just before the emulate line.

[junegunn]

Thanks. Are we trying to support zsh versions older than 5.0.2? zsh 5.0.2 predates fzf so I'm not sure if this is the right goal.

• https://www.zsh.org/mla/announce/msg00117.html
• 03b204e

[romkatv]

If you want to enforce zsh version >= 5, you can do it like this:

if [[ $ZSH_VERSION != <5->.* ]]; then
  print -ru2 -- "Your version of zsh is too old: $ZSH_VERSION < 5.0"
  return 1
fi

I'm not saying you should enforce zsh version >= 5 although in my open source zsh code I do that. The number of users on zsh < 5 is exceedingly tiny.

[LangLangBart]

Thanks. Are we trying to support zsh versions older than 5.0.2? zsh 5.0.2 predates fzf so I'm not sure if this is the right goal.

It's your call to decide, as everything else appears to function properly.

---

I've never encountered this zsh syntax, but it works:

<5->.*

This syntax seems more common:

if (( ${ZSH_VERSION%%.*} < 5 )); then
  echo "Your zsh version is too old: $ZSH_VERSION < 5.0"
  return 1
fi

[romkatv]

Your check is also fine but the echo statement is worse with its couple of tiny bugs. Not a big deal but you might just as well use the correct code if you decide to reject old zsh.

[LangLangBart]

Your check is also fine but the echo statement is worse with its couple of tiny bugs. Not a big deal but you might just as well use the correct code if you decide to reject old zsh.

I will certainly take your advice and use the correct code. Thank you again for your help! I will proceed once the maintainer has made a decision on how to handle the issue.

[junegunn]

I don't think we should put in extra effort to support zsh 4, but this patch is simple and short enough, so I'll merge it. Thanks.