Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if SHELL supports FZF_DEFAULT_COMMAND #3364

Closed
wants to merge 1 commit into from

Conversation

thyssentishman
Copy link

When FZF_DEFAULT_COMMAND is unset, it defaults to a command that depends on 'set -o pipefail'. Since not every shell supports this option, bash was hardcoded as the default shell to be used for this specific case. With this commit, other shells that support this option are first compared to SHELL before depending/falling back to bash.

This commit closes #3339

When FZF_DEFAULT_COMMAND is unset, it defaults to a command that depends
on 'set -o pipefail'. Since not every shell supports this option, bash
was hardcoded as the default shell to be used for this specific case.
With this commit, other shells that support this option are first
compared to SHELL before depending/falling back to bash.
@thyssentishman
Copy link
Author

@junegunn here is an attempt at implementing your suggestion in #3339. I'm new to this codebase and go in general, so apologies in advance for any possible mispractice.

@junegunn
Copy link
Owner

Thanks, I have had an almost identical patch locally, so let me finish this up.

@junegunn junegunn closed this in 547e101 Jul 12, 2023
@thyssentishman
Copy link
Author

Awesome, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bash dependency?
2 participants