-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce '--keep-ansi' option to keep ANSI codes on output #2693
base: master
Are you sure you want to change the base?
Conversation
@7ocb no plan to fix? |
6c7457f
to
8b99a8f
Compare
@blcham I initially intended to but had no time. I just did another attempt now and to be honest I'm not sure how to approach this. The tests on CI failing:
but this test succeeds for me locally (here I commented other tests) :
also the on CI in "test fzf on linux" this test passes also. |
@7ocb ❤️ thanks for the try, not sure how to fix this either |
@blcham also I rebased this PR on top of |
8b99a8f
to
30d156d
Compare
Could it be merged into the original repo? @junegunn |
This improves filtering mode by allowing cases when colors needed to be passed from input to output in filtering mode.
30d156d
to
f707182
Compare
Just rebased this on latest master. |
All checks are green. |
@blcham you need to do
|
@7ocb thanks a lot! it works! However my original issue was not only
Any idea about that? Is |
@blcham likely |
I take it this hasn't gotten implemented? |
This improves filtering mode by allowing cases when colors needed to be passed from input to output in filtering mode.