Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Test with Go 1.10 #26

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Test with Go 1.10 #26

merged 2 commits into from
Feb 21, 2018

Conversation

mjs
Copy link
Contributor

@mjs mjs commented Feb 20, 2018

v1.10 of Go is now officially released so we should be testing against it.

v1.10 of Go is now officially released so we should be testing against
it.
@mjs mjs requested review from amnonbc and oplehto February 20, 2018 09:49
@mjs
Copy link
Contributor Author

mjs commented Feb 20, 2018

Hmmm. For some reason, asking TravisCI to test with Go 1.10.x resulted in it testing with Go 1.7.3. This failed because we're using things in http which were introduced in Go 1.8.

I'll look at this later.

Copy link
Contributor

@amnonbc amnonbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks reasonable.
Travis must be broken.
I imagine they will fix it soon enough.

@oplehto
Copy link
Contributor

oplehto commented Feb 21, 2018

Should be resolved soon: travis-ci/gimme#130

... and use quotes to avoid undesirable YAML float conversion.

See also:
- travis-ci/gimme#132
- travis-ci/gimme#130
@mjs
Copy link
Contributor Author

mjs commented Feb 21, 2018

Worked around the issue for now by asking for "1.10" specifically.

@mjs mjs merged commit 7890cf8 into master Feb 21, 2018
@mjs mjs deleted the go-1.10 branch February 21, 2018 10:20
@mjs mjs removed the do not merge label Feb 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants