Skip to content

Allow arbitrary number of arguments to submit #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2019
Merged

Allow arbitrary number of arguments to submit #797

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
445e863
Allow arbitrary number of arguments to submit
blegat Jul 19, 2019
f00ba2c
Throw MethodError
blegat Jul 19, 2019
9f15e1b
Throw ArgumentError
blegat Jul 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/attributes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,9 @@ end

"""
submit(optimizer::AbstractOptimizer, sub::AbstractSubmittable,
value)::Nothing
values...)::Nothing

Submit `value` to the submittable `sub` of the optimizer `optimizer`.
Submit `values` to the submittable `sub` of the optimizer `optimizer`.

An [`UnsupportedSubmittable`](@ref) error is thrown if `model` does not support
the attribute `attr` (see [`supports`](@ref)) and a [`SubmitNotAllowed`](@ref)
Expand All @@ -388,7 +388,7 @@ error is thrown if it supports the submittable `sub` but it cannot be submitted.
function submit end
function submit(model::ModelLike, sub::AbstractSubmittable, args...)
if supports(model, sub)
throw(SubmitNotAllowed(sub))
throw(MethodError(submit, (model, sub, args...)))
else
throw(UnsupportedSubmittable(sub))
end
Expand Down