Skip to content

[Bridges] fix ConstraintFunction getter of SplitComplexZerosBridge #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blegat merged 2 commits into from
Jul 14, 2022
Merged

[Bridges] fix ConstraintFunction getter of SplitComplexZerosBridge #1953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f453bd2
Get function without cache for SplitComplexZerosBridge
blegat Jul 14, 2022
a446a51
Fix format
blegat Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/Bridges/Constraint/bridges/split_complex_zeros.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ struct SplitComplexZerosBridge{
G<:MOI.Utilities.TypedLike{Complex{T}},
} <: AbstractBridge
dimension::Int
func::G # Simplify querying ConstraintFunction.
constraint::MOI.ConstraintIndex{F,MOI.Zeros}
real_indices::Vector{Int}
imag_indices::Vector{Int}
Expand Down Expand Up @@ -73,7 +72,6 @@ function bridge_constraint(
)
return SplitComplexZerosBridge{T,F,G}(
MOI.dimension(set),
f,
constraint,
real_indices,
imag_indices,
Expand Down Expand Up @@ -112,11 +110,23 @@ function concrete_bridge_type(
end

function MOI.get(
::MOI.ModelLike,
::MOI.ConstraintFunction,
bridge::SplitComplexZerosBridge,
)
return bridge.func
model::MOI.ModelLike,
attr::MOI.ConstraintFunction,
bridge::SplitComplexZerosBridge{T,F,G},
) where {T,F,G}
g = MOI.Utilities.zero_with_output_dimension(G, bridge.dimension)
f = MOI.get(model, attr, bridge.constraint)
S = MOI.Utilities.scalar_type(G)
for (f_i, g_i) in enumerate(bridge.real_indices)
complex_f = convert(S, MOI.Utilities.eachscalar(f)[f_i])
MOI.Utilities.operate_output_index!(+, Complex{T}, g_i, g, complex_f)
end
for (f_i, g_i) in enumerate(bridge.imag_indices)
scalar = MOI.Utilities.eachscalar(f)[length(bridge.real_indices)+f_i]
complex_f = im * scalar
MOI.Utilities.operate_output_index!(+, Complex{T}, g_i, g, complex_f)
end
return g
end

function MOI.get(
Expand Down