Skip to content

[Utilities] fix emptying of CachingOptimizer #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
odow merged 1 commit into from
Sep 16, 2021
Merged

[Utilities] fix emptying of CachingOptimizer #1615

odow merged 1 commit into from
Sep 16, 2021

Conversation

@odow
Copy link
Member

@odow odow commented Sep 15, 2021

@odow odow added Submodule: Utilities About the Utilities submodule Type: Bug labels Sep 15, 2021
@odow
Copy link
Member Author

odow commented Sep 15, 2021

I have a version of SCS passing with this PR.

@odow odow requested a review from blegat September 16, 2021 00:26
@odow odow force-pushed the od/fix-copyoptimize branch from 963d499 to 666431e Compare September 16, 2021 07:20
blegat
blegat approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@blegat blegat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We maybe need another CachingOptimizer state but that is out of the scope of this PR. After a single-shot optimize!, the model is not really empty as is_empty is false.

@odow odow merged commit 91ec097 into master Sep 16, 2021
@odow odow deleted the od/fix-copyoptimize branch September 16, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blegat blegat blegat approved these changes

Assignees

No one assigned

Labels

Submodule: Utilities About the Utilities submodule Type: Bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@odow @blegat