Fix MOI.is_valid for ConstraintIndex{VariableIndex,Parameter} (#415)

jump-dev · Jun 6, 2024 · 92bf61e · 92bf61e
1 parent f5b6ecb
commit 92bf61e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/MOI_wrapper.jl b/src/MOI_wrapper.jl
@@ -165,6 +165,14 @@ function MOI.add_constrained_variable(
     return p, ci
 end
 
+function MOI.is_valid(
+    model::Optimizer,
+    ci::MOI.ConstraintIndex{MOI.VariableIndex,MOI.Parameter{Float64}},
+)
+    p = MOI.VariableIndex(ci.value)
+    return haskey(model.parameters, p)
+end
+
 function MOI.set(
     model::Optimizer,
     ::MOI.ConstraintSet,

diff --git a/test/MOI_wrapper.jl b/test/MOI_wrapper.jl
@@ -336,6 +336,16 @@ function test_parameter_number_of_variables()
     return
 end
 
+function test_parameter_is_valid()
+    model = Ipopt.Optimizer()
+    p, ci = MOI.add_constrained_variable(model, MOI.Parameter(2.0))
+    @test MOI.is_valid(model, p)
+    @test MOI.is_valid(model, ci)
+    @test !MOI.is_valid(model, typeof(p)(p.value + 1))
+    @test !MOI.is_valid(model, typeof(ci)(ci.value + 1))
+    return
+end
+
 function test_parameter_list_of_variable_indices()
     model = Ipopt.Optimizer()
     x = MOI.add_variable(model)