Updates to MOI v0.9 #92
Conversation
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 89.26% 82.92% -6.34%
==========================================
Files 4 4
Lines 419 451 +32
==========================================
Hits 374 374
- Misses 45 77 +32
Continue to review full report at Codecov.
|
mlubin
left a comment
mlubin
left a comment
There was a problem hiding this comment.
LGTM for merging after we tag MOI 0.9.
.travis.yml
Outdated
| notifications: | ||
| email: false | ||
| before_script: | ||
| - julia -e 'using Pkg; Pkg.add(PackageSpec(name="MathOptInterface", rev="master"))' |
There was a problem hiding this comment.
Add a TODO to remove this before merging?
There was a problem hiding this comment.
When MOI is released, I remove this to lines and push to trigger the new build. I'll leave this comment unresolved as a reminder to be sure
| optimizer.options[param.name] = value | ||
| end | ||
| function MOI.get(optimizer::Optimizer, param::MOI.RawParameter) | ||
| return optimizer.options[param.name] |
There was a problem hiding this comment.
TODO: This gives a poor error message if the name of the parameter is invalid.
There was a problem hiding this comment.
We are currently lacking a convention for that. Even UniversalFallback do not have a nice error:
https://github.com/JuliaOpt/MathOptInterface.jl/blob/52d166f91614d5d522bf055cac232c7c5ba3ea96/src/Utilities/universalfallback.jl#L104-L105
Should it be a AttributeNotSetError ? Or just nothing ?
Also drop Julia v0.6, Julia v0.7 and transition from REQUIRE to Project.toml.
Requires jump-dev/MathOptInterface.jl#742, jump-dev/MathOptInterface.jl#743, jump-dev/MathOptInterface.jl#744, jump-dev/MathOptInterface.jl#745, jump-dev/MathOptInterface.jl#746, jump-dev/MathOptInterface.jl#747