Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish norm transition #528

Merged
merged 4 commits into from
Dec 30, 2023
Merged

finish norm transition #528

merged 4 commits into from
Dec 30, 2023

Conversation

ericphanson
Copy link
Collaborator

closes #382

@ericphanson ericphanson requested a review from odow December 30, 2023 00:27
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (15f05fb) 92.24% compared to head (7826281) 92.26%.

Files Patch % Lines
src/atoms/second_order_cone/norm.jl 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   92.24%   92.26%   +0.01%     
==========================================
  Files          86       86              
  Lines        5300     5300              
==========================================
+ Hits         4889     4890       +1     
+ Misses        411      410       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit bb19afb into master Dec 30, 2023
9 checks passed
@odow odow deleted the eph/norm branch December 30, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

norm vs opnorm transition should be completed
2 participants