- 
                Notifications
    You must be signed in to change notification settings 
- Fork 393
fix: php 8.4 deprecation warning about nullable parameters #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Also waiting for these changes. | 
| This change would require a major release ... | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please adjust the GitHub workflow configuration - thx
| 
 updated readme.md also | 
| @DeepDiver1975 Sorry, I don't want to be annoying, but pinging again, maybe notification was lost, hope you see this, please check if all good. We need this. | 
| @jumbojett greetings, is there any extra requirements ? I wonder on possibility this can get released ? | 
| Please release the fixes. | 
| changelog is missing ..... will add on release.... | 
| 
 @DeepDiver1975 Why do you think that a major release is necessary? Is it because this PR dropped support for PHP 7.0? I'm just asking because mixing implicitly nullable parameters with explicitly nullable parameters does not seem to cause any BC breaks (see https://3v4l.org/VmY1C). It would be great to have a new patch release for this package. | 
| When do you plan to release a new release version? | 
| @DeepDiver1975 great PHP 8.4 fixes are merged, please release new tag | 
| 
 Why major? The changes have no impact on current implementations. It can be a patch (according to SemVer principles). | 
| 
 Because php version support changed, this will not run on php 7.0, so in terms of semver for php 7.0 project this is breaking change. | 
With php 8.4 deprecation warnings appear
marking parameter %s as nullable is deprecated, the explicit nullable type must be used insteadTo set nullable type had to bump min. required php version to 7.1 though
List of common tasks a pull request require complete