Skip to content

Conversation

@marksgerasimovs
Copy link
Contributor

@marksgerasimovs marksgerasimovs commented Feb 7, 2025

With php 8.4 deprecation warnings appear
marking parameter %s as nullable is deprecated, the explicit nullable type must be used instead
To set nullable type had to bump min. required php version to 7.1 though

List of common tasks a pull request require complete

  • Changelog entry is added or the pull request don't alter library's functionality

@marksgerasimovs marksgerasimovs marked this pull request as ready for review February 7, 2025 17:44
@ChagarinIvan
Copy link

Also waiting for these changes.

@DeepDiver1975
Copy link
Collaborator

This change would require a major release ...

Copy link
Collaborator

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adjust the GitHub workflow configuration - thx

@ChagarinIvan ChagarinIvan mentioned this pull request Mar 4, 2025
@marksgerasimovs
Copy link
Contributor Author

please adjust the GitHub workflow configuration - thx

updated readme.md also

@marksgerasimovs
Copy link
Contributor Author

@DeepDiver1975 Sorry, I don't want to be annoying, but pinging again, maybe notification was lost, hope you see this, please check if all good. We need this.

@marksgerasimovs
Copy link
Contributor Author

marksgerasimovs commented Apr 14, 2025

@jumbojett greetings, is there any extra requirements ? I wonder on possibility this can get released ?

@q2apro
Copy link

q2apro commented Apr 22, 2025

Please release the fixes.

@DeepDiver1975 DeepDiver1975 changed the title Fix PHP 8.4 deprecation: Implicitly marking parameter as nullable is deppricated fix: php 8.4 deprecation warning about nullable parameters Apr 28, 2025
@DeepDiver1975
Copy link
Collaborator

changelog is missing ..... will add on release....

@DeepDiver1975 DeepDiver1975 merged commit 6496752 into jumbojett:master Apr 28, 2025
9 checks passed
@W0rma
Copy link

W0rma commented Jun 24, 2025

This change would require a major release ...

@DeepDiver1975 Why do you think that a major release is necessary? Is it because this PR dropped support for PHP 7.0?

I'm just asking because mixing implicitly nullable parameters with explicitly nullable parameters does not seem to cause any BC breaks (see https://3v4l.org/VmY1C).

It would be great to have a new patch release for this package.

@miloshynek
Copy link

When do you plan to release a new release version?

@Buzka91
Copy link

Buzka91 commented Jul 16, 2025

@DeepDiver1975 great PHP 8.4 fixes are merged, please release new tag

@ydelwiche
Copy link

This change would require a major release ...

Why major? The changes have no impact on current implementations. It can be a patch (according to SemVer principles).

@marksgerasimovs
Copy link
Contributor Author

This change would require a major release ...

Why major? The changes have no impact on current implementations. It can be a patch (according to SemVer principles).

Because php version support changed, this will not run on php 7.0, so in terms of semver for php 7.0 project this is breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants