fix: add nil check for retryStrategy.Limit in deadline check. Fixes a…

…rgoproj#8990 (argoproj#8991) Signed-off-by: Dillen Padhiar <[email protected]> Signed-off-by: Julie Vogelman <[email protected]>
juliev0 · Jul 14, 2022 · aa957cb · aa957cb
1 parent ff319c6
commit aa957cb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/workflow/controller/operator.go b/workflow/controller/operator.go
@@ -905,7 +905,7 @@ func (woc *wfOperationCtx) processNodeRetries(node *wfv1.NodeStatus, retryStrate
 		}
 
 		// See if we have waited past the deadline
-		if time.Now().Before(waitingDeadline) && int32(len(node.Children)) <= retryStrategy.Limit.IntVal {
+		if time.Now().Before(waitingDeadline) && retryStrategy.Limit != nil && int32(len(node.Children)) <= retryStrategy.Limit.IntVal {
 			woc.requeueAfter(timeToWait)
 			retryMessage := fmt.Sprintf("Backoff for %s", humanize.Duration(timeToWait))
 			return woc.markNodePhase(node.Name, node.Phase, retryMessage), false, nil