Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log statement for BinLogStreamReader.fetchone #608

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Feb 7, 2024

Description

This PR fix the log statement in BinLogStreamReader.fetchone using logging.WARN, which triggers an exception.
I've copied the same logic as the logging statement above, using logging.log(logging.WARN, <statement>) to fix this issue.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Other (please specify below)

Checklist

Tests

  • All tests have passed.
  • New tests have been added to cover the changes. (describe below if applicable).

Additional Information

@bentsku bentsku marked this pull request as ready for review February 7, 2024 14:46
@bentsku
Copy link
Contributor Author

bentsku commented Feb 8, 2024

Apologies for the linting issue, forgot a trailing comma 😬

@bentsku
Copy link
Contributor Author

bentsku commented Feb 9, 2024

Ah, I see. The step in the GitHub Action is running pip install black ruff and those are not versioned, but the pre-commit hook uses pinned versions. Installed the latest versions and called it manually and that fixed it.
Running the lint script manually was using my global ruff install 😅

Anyway, finally now it should be fixed! Sorry for that 😬

@sean-k1
Copy link
Collaborator

sean-k1 commented Feb 14, 2024

@bentsku Hello
I was also checking to see if there was something wrong with LINT, thanks for explaining it so well.
Thanks for the contribution

@sean-k1 sean-k1 merged commit 62cc6f6 into julien-duponchelle:main Feb 14, 2024
6 checks passed
sean-k1 added a commit that referenced this pull request Mar 7, 2024
* Fix parsing of query field of RowsQueryEvent(#602)
* fix log statement for BinLogStreamReader.fetchone(#608)
@sean-k1 sean-k1 mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants