Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added command for auto-completing connection names and fixed bug in c… #455

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

choss
Copy link

@choss choss commented Nov 1, 2021

added command for auto-completing connection names and fixed bug in command line completion

Please check the attached changes, if something like that is wanted. If you give me positive feedback, I will start fixing checkstyle.

@snuyanzin
Copy link
Collaborator

Thanks for your PR.
Could you please describe an issue you are trying to solve and add tests highlighting this issue?

@choss
Copy link
Author

choss commented Nov 1, 2021

Sure. First the descriptions (Tests I can do tomorrow)

  1. Simple problem when configuring a new application config the Command Completion is not updated at all (SqlLine.java) The member variable "sqlLineCommandCompleter" is final and on AppConfig reset it is not recreated. This needs to be done, because the "sqlLineCommandCompleter" is initialized in the constructor before customization happens.

  2. We are using SQL-Line with preconfigured connection yml files. On start we set the filename via custom application. Now we wanted a way to connect to a database server without a) memorizing the configured connections and b) with a command without parameters. (Allthough b is just lazyness on our part). I've added the possibility of tab-completion on configured connection names with a new "special" command which you can also tab-complete, so you don't have to write "connect -c"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants