Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQLLINE-440] Support legacy date/time format #442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SQLLINE-440] Support legacy date/time format #442

wants to merge 1 commit into from

Conversation

richardantal
Copy link

No description provided.

@richardantal richardantal mentioned this pull request Jun 10, 2021
Open
@snuyanzin
Copy link
Collaborator

Thanks for the PR @richardantal
Sorry, I know it is a bit too late however in case you it is possible it would be great if you also add some tests

@richardantal
Copy link
Author

Hi @snuyanzin
I've done manual testing with Phoenix, I used the sqlline with my patch and tested it there.
How do you suggest testing this further in an unittest?

@stoty
Copy link

stoty commented Jan 31, 2024

I have opened
#478 for the same issue.
That patch is smaller, and copies a solution already used in sqlline for numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardantal @snuyanzin @stoty