[SQLLINE-327] !reconnect should respect fastconnect property value

src/main/java/sqlline/Commands.java

@@ -1324,7 +1324,6 @@ public void connect(Properties props, DispatchCallback callback) {
     try {
       sqlLine.getDatabaseConnections().setConnection(connection);
       sqlLine.getDatabaseConnection().getConnection();
-      sqlLine.setCompletions();
       callback.setToSuccess();
     } catch (Exception e) {
       connection.close();

src/main/java/sqlline/DatabaseConnection.java

@@ -180,7 +180,7 @@ public Connection getConnection() throws SQLException {
     }
 
     connect();
-
+    sqlLine.setCompletions();
     return connection;
   }
 

src/test/java/sqlline/CompletionTest.java

@@ -37,6 +37,8 @@
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 /**
  * Test cases for Completions.
@@ -149,7 +151,6 @@ public void testSqlCompletions() {
           begin(sqlLine, os, false, "-e", "!set maxwidth 80");
       assertEquals(status, SqlLine.Status.OK);
       sqlLine.runCommands(new DispatchCallback(),
-          "!set maxwidth 80",
           "!connect "
               + SqlLineArgsTest.ConnectionSpec.H2.url + " "
               + SqlLineArgsTest.ConnectionSpec.H2.username + " "
@@ -176,6 +177,82 @@ public void testSqlCompletions() {
     }
   }
 
+  @Test
+  public void testSqlCompletionsWithoutFastConnect() {
+    try {
+      SqlLine sqlLine = new SqlLine();
+      ByteArrayOutputStream os = new ByteArrayOutputStream();
+      SqlLine.Status status =
+          begin(sqlLine, os, false, "-e", "!set maxwidth 80");
+      assertEquals(status, SqlLine.Status.OK);
+      sqlLine.runCommands(new DispatchCallback(),
+          "!set fastconnect false",
+          "!connect "
+              + SqlLineArgsTest.ConnectionSpec.H2.url + " "
+              + SqlLineArgsTest.ConnectionSpec.H2.username + " "
+              + "\"\"");
+      os.reset();
+
+      LineReader lineReader = sqlLine.getLineReader();
+
+      LineReaderCompletionImpl lineReaderCompletion =
+          new LineReaderCompletionImpl(lineReader.getTerminal());
+      lineReaderCompletion.setCompleter(new SqlLineCompleter(sqlLine));
+      final String tableStartName = "FUNCTION_ALIASE";
+      final String tableStartNameExpected = "FUNCTION_ALIASES";
+      final Set<String> tableAndColumns =
+          getLineReaderCompletedSet(lineReaderCompletion, tableStartName);
+      assertFalse(tableAndColumns.isEmpty());
+      assertTrue(tableAndColumns.stream()
+          .allMatch(t -> t.startsWith(tableStartNameExpected)));
+    } catch (Exception e) {
+      // fail
+      throw new RuntimeException(e);
+    }
+  }
+
+  @Test
+  public void testSqlCompletionsWithAndWithoutFastConnect() {
+    try {
+      SqlLine sqlLine = new SqlLine();
+      ByteArrayOutputStream os = new ByteArrayOutputStream();
+      SqlLine.Status status =
+          begin(sqlLine, os, false, "-e", "!set maxwidth 80");
+      assertEquals(status, SqlLine.Status.OK);
+      sqlLine.runCommands(new DispatchCallback(),
+          "!set fastconnect true",
+          "!connect "
+              + SqlLineArgsTest.ConnectionSpec.H2.url + " "
+              + SqlLineArgsTest.ConnectionSpec.H2.username + " "
+              + "\"\"");
+      os.reset();
+
+      LineReader lineReader = sqlLine.getLineReader();
+
+      LineReaderCompletionImpl lineReaderCompletion =
+          new LineReaderCompletionImpl(lineReader.getTerminal());
+      lineReaderCompletion.setCompleter(new SqlLineCompleter(sqlLine));
+      final String tableStartNameInput = "FUNCTION_ALIASE";
+      final String tableStartNameExpected = "FUNCTION_ALIASES";
+      final Set<String> tableAndColumns =
+          getLineReaderCompletedSet(lineReaderCompletion, tableStartNameInput);
+      assertFalse(tableAndColumns.stream()
+          .allMatch(t -> t.startsWith(tableStartNameExpected)));
+
+      sqlLine.runCommands(new DispatchCallback(),
+          "!set fastconnect false",
+          "!reconnect");
+      os.reset();
+      final Set<String> tableAndColumnsAfterReconnect =
+          getLineReaderCompletedSet(lineReaderCompletion, tableStartNameInput);
+      assertTrue(tableAndColumnsAfterReconnect.stream()
+          .allMatch(t -> t.startsWith(tableStartNameExpected)));
+    } catch (Exception e) {
+      // fail
+      throw new RuntimeException(e);
+    }
+  }
+
   private LineReaderCompletionImpl getDummyLineReader() {
     try {
       TerminalBuilder terminalBuilder = TerminalBuilder.builder();

src/test/java/sqlline/SqlLineArgsTest.java

@@ -780,7 +780,7 @@ public void testRecordHome() {
    */
   @Test
   public void testRecordFilenameWithSpace() {
-    final String fileNameWithSpaces = "sqlline' file\" with\\ spaces";
+    final String fileNameWithSpaces = "sqlline' file with spaces";
     File file = createTempFile(fileNameWithSpaces, ".log");
     final SqlLine sqlLine = new SqlLine();
     final String script = "!set incremental true\n"
@@ -2603,7 +2603,7 @@ void setNickname(String nickname) {
       };
       final SqlLine sqlLine = new SqlLine();
       ByteArrayOutputStream os = new ByteArrayOutputStream();
-      final String filename = "file' with\\\" spaces";
+      final String filename = "file' with spaces";
       String[] connectionArgs = new String[] {
           "-u", ConnectionSpec.H2.url,
           "-n", ConnectionSpec.H2.username,