Update junit to junit5 and checkstyle to checkstyle 8 #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR
checkstyle 7.8.2 => 8.16
junit 4.12 => 5.3.2
maven-assembly-plugin 3.0.0 => 3.1.1
maven-dependency-plugin 2.10 => 3.1.1
maven-enforcer-plugin 3.0.0-M1 => 3.0.0-M2
maven-jar-plugin 3.0.0 => 3.1.1
SuppressionCommentFilter
,SuppressionCommentFilter
,SuppressWithNearbyCommentFilter
underTreeWalker
and removesFileContentsHolder
as it is declared in checkstyle's RN http://checkstyle.sourceforge.net/releasenotes.html#Release_8.2assertEquals
as its signature changed (message started to be the last argument)assertArrayEquals
where it is possibleFiles.createTempFile
for temporary files as junit5 has limited support of temporary filesfixes #265