Application class update #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Renamed commandhandler package to extensions. 2. Moved CustomApplication to extensions package. 3. OutputFormat and AbstractOutputFormat are made public. 4. Formats and command handlers holders are made immutable: 4.1. Config class in Sqlline wraps all given constructor parameters into unmodifiable objects. 4.2. Two clone methods were added into Config class to clone its content when formats / command handlers are changed. 4.3. Two methods to update formats / command handlers are added into Sqlline class which clones and re-assigns Config. 5. Added unit test to demonstrate how application configuration can be reset at runtime. 6. Updated javadocs.
arina-ielchiieva
force-pushed
the
106-application
branch
from
9f1c9cc
to
0b6ca84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.1. Config class in Sqlline wraps all given constructor parameters into unmodifiable objects.
4.2. Two clone methods were added into Config class to clone its content when formats / command handlers are changed.
4.3. Two methods to update formats / command handlers are added into Sqlline class which clones and re-assigns Config.