fix: upgrade emitter dependency to fix license issue #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just noticed #6 and this PR fortunately also fixes that |
jorenbroekema
force-pushed
the
update-emitter
branch
from
05c3ea9
to
709caa9
Compare
jorenbroekema
force-pushed
the
update-emitter
branch
from
709caa9
to
04df5c4
Compare
juliangruber
requested changes
Jun 26, 2024
|
Thanks! Published as 0.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11
I wasn't sure how to run the makefile/tests, the make command gives me an error and it's not entirely clear to me how the
test.htmlis ran exactly.If needed I could modernize the test setup a little bit and ensure none of the tests broke with this dependency upgrade, or you can check things manually yourself, let me know.