Allow lts for the LTS, and allow pre for the latest pre-release
#234
Conversation
Yea, seems fine to require an action update for that once every few years. For some reason the GHA logs aren't showing me the error properly except in the raw logs, it's That CI check still runs on Node16. #235 should fix it |
for now, this just hardcodes the LTS version in the source (similar to how juliaup does it) since the latest LTS is not available in `versions.json`. Since the LTS is updated so rarely this might be ok for now.
|
Can we get this merged? |
|
Hmmm. PR Checks are still failing. |
DilumAluthge
changed the title
lts to install the latest LTS versionlts for the LTS, and allow pre for the latest pre-release
| }) | ||
|
|
||
| it('pre', () => { | ||
| expect(installer.getJuliaVersion(testVersions, 'pre')).toEqual('1.11.0-beta1') |
There was a problem hiding this comment.
@KristofferC Will this test will need to be updated every time there's a new pre-release?
|
We should decide on a case (uppercase vs lowercase) convention, and keep it consistent between this PR and #202. Which do we prefer?
|
DilumAluthge
requested review from
omus,
IanButterworth,
a team and
SaschaMann
and removed request for
SaschaMann
|
Phew, CI is all green now. |
|
Nice! Will |
|
I'm working on testing this on an external repo to demo it, then will update the readme for review, before releasing 2.2.0 |
|
There are failures in the package on apple silicon, ignore those, but otherwise seems good |
|
@ViralBShah check the readme under https://github.com/julia-actions/setup-julia#examples If that looks good then I can release v2.2.0 |
|
I proposed #256 |
for now, this just hardcodes the LTS version in the source (similar to how juliaup does it) since the latest LTS is not available in
versions.json. Since the LTS is updated so rarely this might be ok for now.