Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Update cookbooks #858

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

feat(docs): Update cookbooks #858

wants to merge 4 commits into from

Conversation

HamadaSalhab
Copy link
Contributor

@HamadaSalhab HamadaSalhab commented Nov 21, 2024

Important

Standardized cookbook file names and removed outdated files for improved consistency and organization.

  • File Renames:
    • 01-Website_Crawler_using_Spider.py to 01-website-crawler.py.
    • 02-Sarcastic_News_Headline_Generator.py to 02-sarcastic-news-headline-generator.py.
    • 04-TripPlanner_With_Weather_And_WikiInfo.py to 03-trip-planning-assistant.py.
    • 17-Hook-Generator-Trending-Reels.py to 04-hook-generator-trending-reels.py.
  • File Deletions:
    • Removed 13 outdated files including 03-SmartResearcher_With_WebSearch.py, 05-Basic_Agent_Creation_and_Interaction.py, and 06-Designing_Multi-Step_Tasks.py.

This description was created by Ellipsis for 27fe0e6. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 359b9dd in 21 seconds

More details
  • Looked at 2238 lines of code in 17 files
  • Skipped 12 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_Ymo8jj1VRpW1mZdf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 27fe0e6 in 47 seconds

More details
  • Looked at 150 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. cookbooks/03-trip-planning-assistant.py:62
  • Draft comment:
    Using f-strings for API keys can expose them in logs or error messages. Consider using placeholders and replacing them at runtime.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. cookbooks/03-trip-planning-assistant.py:69
  • Draft comment:
    Using f-strings for API keys can expose them in logs or error messages. Consider using placeholders and replacing them at runtime.
  • Reason this comment was not posted:
    Marked as duplicate.
3. cookbooks/03-trip-planning-assistant.py:142
  • Draft comment:
    Consider using a dynamic approach to check for task completion instead of a fixed sleep time.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The sleep time is set to 200 seconds, which might be arbitrary and could lead to inefficient waiting. Consider using a more dynamic approach to check for task completion.
4. cookbooks/04-hook-generator-trending-reels.py:6
  • Draft comment:
    Using f-strings for API keys can expose them in logs or error messages. Consider using placeholders and replacing them at runtime.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_08NcLqQCMOUfVtoi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped PR review on 0e8c707 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants