Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Evaluate Step error #518

Closed
wants to merge 2 commits into from
Closed

Fix Evaluate Step error #518

wants to merge 2 commits into from

Conversation

HamadaSalhab
Copy link
Contributor

@HamadaSalhab HamadaSalhab commented Sep 24, 2024

Important

Adds preprocessing in simple_eval_dict to convert Jinja-like syntax to Python format before evaluation.

  • Behavior:
    • Adds preprocess_expression function in simple_eval_dict to convert Jinja-like syntax to Python format using re2.sub.
    • Modifies simple_eval_dict to preprocess expressions before evaluation.

This description was created by Ellipsis for d28c77c. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d28c77c in 22 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/activities/utils.py:64
  • Draft comment:
    Consider using the re module instead of re2 for regex operations unless re2 is specifically required for performance or compatibility reasons.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of re2 for regex operations is not standard in Python. Typically, the re module is used. This could lead to confusion or compatibility issues if re2 is not properly installed or if its behavior differs from re.

Workflow ID: wflow_ZemrrQZ5mnphKxsy


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@HamadaSalhab HamadaSalhab linked an issue Sep 24, 2024 that may be closed by this pull request
@HamadaSalhab HamadaSalhab changed the title Add preprocessing for values in simple_eval_dict Fix Evaluate Step error Sep 24, 2024
@creatorrr
Copy link
Contributor

I didn't understand why this is necessary. can you explain the bug a lil more, @HamadaSalhab ?

@HamadaSalhab HamadaSalhab deleted the x/fix-evaluate-step branch September 24, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate Step Throws "unhashable type: 'set'" Error
2 participants