Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents-api): Toy implementation of Tasks #391

Merged
merged 9 commits into from
Jun 11, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Jun 6, 2024

🚀 This description was created by Ellipsis for commit 6ea6946

Summary:

This PR updates execution statuses and transition types across the agents API for improved clarity and consistency.

Key points:

  • Renamed execution.status and transition.type in agents-api.
  • Updated related models, types, and database migrations.
  • Aimed at improving clarity and consistency in execution-related terminology.

Generated with ❤️ by ellipsis.dev

@creatorrr creatorrr requested a review from alt-glitch June 6, 2024 21:31
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 84725bc in 1 minute and 44 seconds

More details
  • Looked at 2781 lines of code in 15 files
  • Skipped 2 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/python/julep/api/types/tool_response.py:15
  • Draft comment:
    Ensure that all instances of ToolResponse creation across the codebase are updated to include an id, as it is now a mandatory field.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_AkFalMOiIEgncpoF


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Signed-off-by: Diwank Tomer <[email protected]>
@creatorrr creatorrr enabled auto-merge (squash) June 6, 2024 21:42
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 6ea6946 in 1 minute and 58 seconds

More details
  • Looked at 116 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/python/julep/api/types/workflow_step.py:2
  • Draft comment:
    The PR description mentions renaming execution statuses and transition types, but the provided diff does not show any changes related to these elements. Please ensure the PR accurately reflects the changes made.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_EfajafMTHFdG7B5L


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

auto-merge was automatically disabled June 10, 2024 18:06

Head branch was modified

@creatorrr creatorrr changed the title feat(agents-api): Rename execution.status & transition.type feat(agents-api): Toy implementation of Tasks Jun 11, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this basically reads and correctly serializes the data sent from temporal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we define the tworkflows (temporal workflows)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tworkflows defined in task_steps/__init__.py are executed from here

@creatorrr creatorrr merged commit 67e93c1 into dev-tasks Jun 11, 2024
3 of 6 checks passed
@creatorrr creatorrr deleted the f/task-execution-workflow branch June 11, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants