-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agents-api): Toy implementation of Tasks #391
Conversation
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 84725bc in 1 minute and 44 seconds
More details
- Looked at
2781
lines of code in15
files - Skipped
2
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. sdks/python/julep/api/types/tool_response.py:15
- Draft comment:
Ensure that all instances ofToolResponse
creation across the codebase are updated to include anid
, as it is now a mandatory field. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_AkFalMOiIEgncpoF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 6ea6946 in 1 minute and 58 seconds
More details
- Looked at
116
lines of code in6
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. sdks/python/julep/api/types/workflow_step.py:2
- Draft comment:
The PR description mentions renaming execution statuses and transition types, but the provided diff does not show any changes related to these elements. Please ensure the PR accurately reflects the changes made. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_EfajafMTHFdG7B5L
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
Head branch was modified
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this basically reads and correctly serializes the data sent from temporal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we define the tworkflows (temporal workflows)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tworkflows defined in task_steps/__init__.py
are executed from here
Summary:
This PR updates execution statuses and transition types across the agents API for improved clarity and consistency.
Key points:
execution.status
andtransition.type
inagents-api
.Generated with ❤️ by ellipsis.dev