-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/bb sdk v1.0: Updating the BrowserBase SDK from v0.x to v1.x #1033
base: dev
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14144715 | Triggered | Generic Password | 253c732 | deploy/simple-docker-compose.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
CI Failure Feedback 🧐(Checks updated until commit 2cdcb62)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to b033fb4 in 1 minute and 2 seconds
More details
- Looked at
365
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. integrations-service/uv.lock:229
- Draft comment:
Use 'sys_platform' instead of 'platform_system' for consistency.
{ name = "colorama", marker = "sys_platform == 'win32'" },
- Reason this comment was not posted:
Confidence changes required:50%
The code is using 'platform_system' instead of 'sys_platform' in the marker for 'colorama'. This should be consistent with the other changes in the lock file.
Workflow ID: wflow_H77qeuBHPO1bmrlC
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
integrations-service/integrations/utils/integrations/browserbase.py
Outdated
Show resolved
Hide resolved
…se.py Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
PR Type
Enhancement, Bug fix
Description
Updated the BrowserBase SDK integration to v1.0.
Refactored session handling methods for improved clarity.
Enhanced error handling in session and extension operations.
Updated dependencies to use the latest BrowserBase SDK version.
Changes walkthrough 📝
browserbase.py
Update models to align with BrowserBase SDK v1.0
integrations-service/integrations/models/browserbase.py
connectionUrl
field toBrowserbaseCreateSessionOutput
.DebugConnectionURLs
withSessionLiveURLs
.browserbase.py
Refactor and enhance BrowserBase integration utilities
integrations-service/integrations/utils/integrations/browserbase.py
pyproject.toml
Update BrowserBase SDK dependency version
integrations-service/pyproject.toml
browserbase
dependency to version>=1.0.5
.Important
Update BrowserBase SDK to v1.x, modifying imports, function calls, and error handling in
browserbase.py
, and updating dependencies inpyproject.toml
anduv.lock
.Browserbase
SDK from v0.x to v1.x, changing imports and function calls inbrowserbase.py
.browserbase.py
.create_session
to usesessions.create()
andget_session
to usesessions.retrieve()
.browserbase
dependency to>=1.0.5
inpyproject.toml
anduv.lock
.get_browserbase_client()
inbrowserbase.py
.TypeAdapter
forBrowserSettings
increate_session
function.This description was created by for b033fb4. It will automatically update as commits are pushed.