-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D/cookbooks: Added new cookbooks #1020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 0e689d9 in 10 seconds
More details
- Looked at
48
lines of code in3
files - Skipped
6
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. memory-store/README.md:3
- Draft comment:
Ensure that the change frompgmigrate
tomigrate
is consistent throughout the documentation. The command in step 3 has been updated correctly. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the command frompgmigrate
tomigrate
in thememory-store/README.md
file. This change should be reflected consistently throughout the file.
Workflow ID: wflow_0BkrTHIo5dtKrA9X
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
CI Failure Feedback 🧐(Checks updated until commit 0819e0e)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues flagged.
Standard Input can make mistakes. Check important info.
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on cc93353 in 10 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/tests/test_docs_queries.py:275
- Draft comment:
The parameter name was changed fromquery_embedding
toembedding
in thesearch_docs_by_embedding
function call. Ensure this aligns with the function's expected parameters. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_KZqjutIRkfZj0WFE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 0819e0e in 11 seconds
More details
- Looked at
22
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/pyproject.toml:26
- Draft comment:
The dependency versioning syntax forlitellm
is incorrect. It should belitellm~=1.57.0
instead oflitellm~1.57.0
. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_f4970JCerQ0iWjlx
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
PR Type
Documentation, Enhancement
Description
Added a new Jupyter Notebook
09_companion_agent.ipynb
demonstrating companion agent capabilities.Updated
cookbooks/README.md
to include new cookbooks and their descriptions.Enhanced migration instructions in
memory-store/README.md
for clarity and updated tool usage.Changes walkthrough 📝
3 files
Added a new notebook for companion agent tasks
Updated README to include new cookbooks
Updated migration instructions for clarity
6 files
Important
Add new Jupyter Notebook for companion agent, update READMEs, rename parameter in test, delete JSON file, and comment out dependency source.
09_companion_agent.ipynb
to demonstrate companion agent capabilities.cookbooks/README.md
to include new cookbooks and remove outdated ideas.memory-store/README.md
for clarity.query_embedding
toembedding
insearch_docs_by_embedding()
intest_docs_queries.py
.test-chat.json
fromagents-api/notebooks
.litellm
source inpyproject.toml
.This description was created by
for 0819e0e. It will automatically update as commits are pushed.