fix: Fix handlers calls

[whiterabbit1983]

PR Type

Bug fix, Enhancement

---

Description

• Removed unnecessary ProcessPoolExecutor and related code for synchronous handlers.

• Simplified handler calls by directly invoking them asynchronously.

• Improved error handling and streamlined code for execute_system.

• Removed redundant checks for coroutine functions in handler logic.

---

Changes walkthrough 📝

	Relevant files
Bug fix	execute_system.py Simplified handler calls and removed redundant logic          agents-api/agents_api/activities/execute_system.py Removed ProcessPoolExecutor and related asynchronous execution logic. Simplified handler calls by directly invoking them. Improved maintainability by removing redundant coroutine checks. Streamlined error handling and reduced code complexity. +13/-57

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

---

Important

Simplifies execute_system by removing ProcessPoolExecutor and assuming handlers are asynchronous.

• Behavior:
  • Simplifies execute_system in execute_system.py by removing ProcessPoolExecutor and asyncio checks.
  • Assumes handlers are asynchronous, directly awaiting handler calls for create, update operations on session and user resources.
• Code Removal:
  • Removes asyncio and ProcessPoolExecutor imports and related code.
  • Deletes code handling synchronous functions in separate processes.

^{This description was created by for 2f60f03. It will automatically update as commits are pushed.}

[qodo-merge-pro-for-open-source]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Error Handling The PR removes the FIXME comment about process pool error handling but doesn't verify if the new direct async calls properly handle and propagate exceptions from handlers return await handler(**arguments) except BaseException as e: if activity.in_activity(): activity.logger.error(f"Error in execute_system_call: {e}") raise Handler Assumptions The code now assumes all handlers are async-compatible without any fallback for potentially synchronous handlers, which could cause runtime errors return await handler( developer_id=developer_id, session_id=session_id, data=create_session_request, ) # Handle update session if system.operation == "update" and system.resource == "session": developer_id = arguments.pop("developer_id") session_id = arguments.pop("session_id") update_session_request = UpdateSessionRequest(**arguments) return await handler( developer_id=developer_id, session_id=session_id, data=update_session_request, ) # Handle update user if system.operation == "update" and system.resource == "user": developer_id = arguments.pop("developer_id") user_id = arguments.pop("user_id") update_user_request = UpdateUserRequest(**arguments) return await handler( developer_id=developer_id, user_id=user_id, data=update_user_request, ) return await handler(**arguments)

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 2f60f03 in 14 seconds

More details

• Looked at 108 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. agents-api/agents_api/activities/execute_system.py:142

• Draft comment:
  Ensure all handlers are asynchronous to avoid blocking the event loop. If any handler is synchronous, consider using run_in_executor to prevent performance issues.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_SPY2ASvrq5DXux09

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[qodo-merge-pro-for-open-source]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Verify handler is awaitable before executing to prevent runtime errors Add error handling for the case when the handler is not awaitable but is called with await, which could happen now that the ProcessPoolExecutor was removed. agents-api/agents_api/activities/execute_system.py [142] -return await handler(**arguments) +if asyncio.iscoroutinefunction(handler): + return await handler(**arguments) +raise TypeError(f"Handler {handler.__name__} must be a coroutine function") Apply this suggestion Suggestion importance[1-10]: 9 Why: This is a critical suggestion as the PR removes ProcessPoolExecutor but doesn't add checks for awaitable handlers, which could lead to runtime errors. Adding this validation is essential for maintaining proper async execution flow.	9
	Add input validation to prevent runtime errors from invalid argument types Add error handling for invalid arguments before calling the handler. Verify that required parameters exist and have correct types to prevent runtime errors. agents-api/agents_api/activities/execute_system.py [112-116] +if not isinstance(developer_id, UUID): + raise ValueError("developer_id must be a valid UUID") +if session_id and not isinstance(session_id, UUID): + raise ValueError("session_id must be a valid UUID") return await handler( developer_id=developer_id, session_id=session_id, data=create_session_request, ) Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion adds important type validation for UUID fields before handler execution, which can prevent runtime errors and provide clearer error messages. This is particularly valuable since the code handles critical session management.	7