PR-CS-8: Association strength (ΔR²) — per-scope effect-size guide for the Analyze Wall#290
Merged
Merged
Conversation
…n strength) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t framing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r the 3 sort sites)
Part A — integration test that uses the REAL engine to prove drilling into a scope (Region=A, with Region constant) re-ranks the vital few from [Region] to [Machine]. Fixture required a 500-unit Region gap vs 8-unit Machine effect to make Region's marginal ΔR² globally dominant over Machine's. Part B — strengthens the existing ΔR² presence test with a numeric-signal guard (parseFloat > 0) to catch dead-wiring where all values fall back to 0. Part C — skipped: shiftDominatedRows keeps only one factor (Shift); a two-kept-factor deterministic fixture fiddly enough to risk brittleness. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…+ balanced wobble
…ect-size-with-p)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jukka-matti
added a commit
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Surfaces each factor's semipartial R² ("association strength, ΔR²") in the Analyze Wall's
ModelBuilderBand— the unique share of the spread each factor accounts for inside the drilled scope. An association magnitude paired with the existing partial p, framed explicitly as a clue to investigate, never a cause verdict.Closes PR-CS-8 of the connective-surface redesign (sub-plan:
docs/superpowers/plans/2026-06-02-cs-8-association-strength.md).Commits (8)
feat(stats)—perFactorDeltaR2pure helper (semipartial R², O(1) reads off the enumerated subset index, no new regression; raw R² so ≥0, clamped)test(stats)— empty-baseline ΔR² coverage + decouple tests from the subset-key encodingfeat(i18n)— 4 association-strength/ΔR² labels across all 32 locales + theMessageCataloginterfacefeat(analyze)— render per-factor ΔR² bars + value + a "not a verdict" framing line; re-point capturedtopFactorto highest-ΔR²refactor(analyze)— extractbyDeltaR2Desc(single comparator for the 3 sort sites)test(analyze)— lock in per-scope vital-few re-rank on drill + ΔR² numeric-signal guardtest(analyze)— make the re-rank test load-bearing (junkNoisecandidate + balanced wobble)docs(cs-8)— refine LOCKED chore(deps): bump actions/upload-artifact from 4.6.2 to 7.0.0 #2 → effect-size-with-p (spec §2 + decision-log + source headers)Design (pinned in the sub-plan)
R²(kept) − R²(kept∖f)for a kept factor; gain-on-add for a candidate) — the same numerator the nested-F partial p is built on. The effect size paired with the existing p.Grounding corrections during build (logged for the method record)
MessageKeyunion, butMessageCatalogis a closed interface with 32 hand-maintained complete locale catalogs (English placeholders are the convention for technical labels, perfe-1/fe-2a/fe-2b). Synced via a deterministic script; verified by the tsc build + the 70-test i18n completeness suite.Noisecandidate that must NOT be kept in Region A, so the assertion genuinely requires per-scope recomputation.Verification
pr-ready-check.sh: ✓ all checks passed (full turbo test + 4 builds + lint + boundary + dist integrity).rSquaredcorrectness, ADR-073 non-summing, never-a-verdict framing, i18n completeness, and thattopFactor's two downstream consumers only map it tolinkedFactor(no p-ordering assumption).Non-blocking follow-ups (Minor, from final review)
overflow-autoso it scrolls, not clips. Worth a glance at laptop width in the real Wall.🤖 Generated with Claude Code