feat(8f): PR1 Foundation — shape-change wallLayoutStore to useCanvasViewportStore#160
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jukka-matti
added a commit
that referenced
this pull request
May 13, 2026
3-agent retrospective on shipped 8f (PRs #160-#165) surfaced 20 findings: 5 HIGH, 8 MEDIUM, 7 LOW. Vision §5.4 closure has known scope gaps — most notably the ADR-081 §2 Azure Blob sync commitment is unmet, and AuthorL3View parallel-implements FRAME column-assignment in violation of the ADR-074 amendment that ADR-081 codifies. - decision-log.md: Amendment 2026-05-13 block on the "8f SHIPPED" entry acknowledging the 5 HIGH gaps - investigations.md: new "8f followups" entry with full 20-finding enumeration + file:line references - roadmap.md §2: followup workstream promoted to "in flight" - docs/superpowers/plans/2026-05-13-canvas-viewport-8f-followups.md: 6-PR cleanup plan (PR0 direct-to-main; PR1-PR6 via subagent-driven-development) Co-Authored-By: ruflo <ruv@ruv.net>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wallLayoutStoreintouseCanvasViewportStorewithviewports: Record<ProcessHubId, CanvasViewportSnapshot>, hub-keyed persistence, lifecycle hooks, and updated PWA/Azure/UI consumers.Test Plan
pnpm --filter @variscout/pwa test -- --run src/components/views/__tests__/InvestigationView.mapwall.test.tsx src/components/views/__tests__/FrameView.test.tsxpnpm --filter @variscout/ui test -- --run src/components/Canvas/__tests__/CanvasWorkspace.test.tsxrg -n "useWallLayoutStore|persistWallLayout|rehydrateWallLayout|useWallLayoutLifecycle|WallLayoutSnapshot|WALL_LAYOUT_STORE_LAYER" apps packages --glob '*.{ts,tsx}'(no matches)bash scripts/pr-ready-check.shpnpm --filter @variscout/ui buildNotes
035d7523, then re-reviewed with no findings.