PR-RPS-5: Improvement Project V1 — engine layer (types + persistence + store + .vrs + D18 primitives)#150
Merged
Merged
Conversation
Co-Authored-By: ruflo <ruv@ruv.net>
…ATE patch + clarify sections deep-merge JSDoc Co-Authored-By: ruflo <ruv@ruv.net>
…rovementProjects table
…ia HUB_PERSIST_SNAPSHOT Co-Authored-By: ruflo <ruv@ruv.net>
…mprovementProjects table (v10) Co-Authored-By: ruflo <ruv@ruv.net>
…spatch fixture Critical-1: update AzureHubRepository.test.ts fixture to include improvementProjects on the dispatched hub so the saveProcessHubToIndexedDB assertion actually exercises the decomposition path (previous fixture had no IPs, making hubWithoutIP === hub structurally and the assertion vacuously pass). Critical-2: add AzureHubRepository.snapshot.test.ts — real-Dexie integration tests (fake-indexeddb/auto) that verify the decomposition contract end-to-end: hub blob stored without IPs, IPs written to dedicated table, empty/absent IP arrays leave table empty, and stale IPs absent from the new snapshot are deleted. Co-Authored-By: ruflo <ruv@ruv.net>
…jection Co-Authored-By: ruflo <ruv@ruv.net>
… (D18) Co-Authored-By: ruflo <ruv@ruv.net>
…ections contract + type Azure mocks `IMPROVEMENT_PROJECT_UPDATE` patch.sections is now `Partial<ImprovementProject['sections']>` so callers can supply a single sub-section key without TS2739. Matches the JSDoc shallow-merge contract and the test fixtures in both persistence handler suites. Azure mock signatures updated to `vi.fn<(hub: ProcessHub) => Promise<void>>()` / `vi.fn<(action: HubAction) => Promise<void>>()` so mock.calls[0][0] destructuring (TS2493 / TS2352) resolves correctly. Added a compile-time test in exhaustiveness.test.ts documenting the partial-sections contract at the type level. Co-Authored-By: ruflo <ruv@ruv.net>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jukka-matti
added a commit
that referenced
this pull request
May 13, 2026
…80, log shipment All 10 PRs of Response Path System V1 merged on main 2026-05-09 → 2026-05-13 (#144 / #147 / #148 / #149 / #150 / #151 / #152 / #153 / #154 / #155). This commit syncs tracking docs that the squash merges left stale: - docs/roadmap.md: PR-RPS-9 + PR-RPS-10 SHIPPED rows; flip §3 to "10 of 10"; free up ADR-080 slot from the 8f canvas viewport item (taken by Sustainment) - docs/decision-log.md: pin "2026-05-13 — RPS V1 SHIPPED — full lifecycle live" - docs/07-decisions/adr-080-sustainment-auto-fire-pattern.md (new): document the Sustainment-shaped lifecycle pattern (auto-fire + Inbox prompt + signoff tier gate) as a pattern reference for future response-path lifecycles, per plan §PR-RPS-9 ledger line 2231 - docs/07-decisions/index.md: add rows 078 / 079 / 080 (078+079 also weren't indexed when shipped) - Spec + plan frontmatter: draft/active → delivered, last-reviewed 2026-05-13 Co-Authored-By: ruflo <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine-only PR for
ImprovementProjectper Response Path System V1 spec §3 D8/D9 + §11 D18. No UI surface yet — that lands in PR-RPS-6.What this delivers
ImprovementProjecttype tree in@variscout/corewith multi-level Y/X/xGoal(D9)IMPROVEMENT_PROJECT_*HubAction kinds (CREATE / UPDATE / ARCHIVE) with locked deep-merge contractProcessHub.improvementProjects?: ImprovementProject[]hydrated optional fieldjoinHubhydration,HUB_PERSIST_SNAPSHOTdecompositionAzureHubRepository.dispatchdecomposes IP into the dedicated table within a single transaction;hubs.get/listhydrateuseImprovementProjectStoreDocument-layer Zustand store (STORE_LAYER='document', nopersistmiddleware) — 4-method API:setProjectsForHub,getProjectsForHub,upsertProject,removeProject.vrsround-trip tests covering populated, legacy (no field), and empty-array hubscomputeSourceHash+shouldShowDrift(pure logic in@variscout/core) anduseLiveProjection(memoized FK→entity hook in@variscout/hooks)Locked deep-merge contract (
IMPROVEMENT_PROJECT_UPDATE)Documented as JSDoc on the action type and implemented identically in PWA + Azure handlers:
metadata,goal,signoff, and the foursectionskeysmetadata.financialImpactandgoal.outcomeGoalalso shallow-mergesectionsshallow-merges per sub-section key — missing keys preserved from existingmetadata.team[],goal.factorControls[],goal.mechanismGoals[], all FK arrays insidesections.*)id,createdAt,hubId,deletedAt,updatedAtexcluded from the patch type at compile timeupdatedAtset by handler toDate.now()The patch type itself is
Partial<Omit<ImprovementProject, 'id' | 'createdAt' | 'hubId' | 'updatedAt' | 'deletedAt' | 'sections'>> & { sections?: Partial<ImprovementProject['sections']> }so partial-sections patches type-check and the documented contract is enforced.Tests
@variscout/core@variscout/stores@variscout/hooks@variscout/pwa@variscout/azure-appbash scripts/pr-ready-check.shgreen.pnpm --filter @variscout/ui buildgreen.Migration / back-compat
Per spec §8/§9 strict no-back-compat. PWA stays on Dexie v1 (table appended to existing version block); Azure bumps 9 → 10 with a new empty
improvementProjectstable — no upgrade callback needed; existing dev IDBs get the new table on next open..vrsfiles written by older versions import cleanly withimprovementProjectsundefined (test coverage inserialization/__tests__/roundtrip.test.ts).Followups deferred (non-blocking)
../typesrather than../index(precedent issue, low-impact)hubs.getreturns plain hub when only archived IPs exist — not reachable from PR-RPS-5; PR-RPS-6 should either avoid the trigger or read archived IPs into the round-tripnextByHublocal annotation cosmetic; T7 distinct-hash test for null vs undefinedPlan
docs/superpowers/plans/2026-05-09-response-path-system-v1.mdlines 1559–1844. Spec atdocs/superpowers/specs/2026-05-09-response-path-system-v1-design.md. Unblocks PR-RPS-6 (6-section IP UI).Test plan
pnpm testgreen in all 6 packagesbash scripts/pr-ready-check.shgreenpnpm --filter @variscout/ui buildgreenpnpm --filter @variscout/pwa buildgreenpnpm --filter @variscout/azure-app buildgreen.vrsround-trip preserves IPs (rich + minimal + empty + legacy)🤖 Generated with ruflo