feat: full EvidenceSheet rendering (Phase 3 PR #2)#101
Merged
Conversation
…ndingsFor Replaces the synthetic-Finding placeholder pattern from PR #99 with a clean separation of concerns: - countFor (sync) — chip badge count, derived from rollup metadata - loadFindingsFor (async) — fetches real findings for the sheet, only called when consumer wires it after chip click - onChipClick(item) — telemetry signal, no findings arg - onFindingSelect(item, finding) — sheet's selection callback Sheet management stays on the consumer side (next task wires Dashboard). Eliminates the 'as unknown as readonly Finding[]' cast and the synthetic- placeholder generation entirely. Existing chip tests rewritten for the new contract; 2 new tests added (no-load-on-render guard + onFindingSelect contract presence). Phase 3 PR #2, Task 2. Co-Authored-By: ruflo <ruv@ruv.net>
Lightweight sheet listing findings (label + status badge + click-thru). Renders nothing when item is null; loading state when findings is null; empty state for zero findings. Esc key, click-outside, and close button all fire onClose. Phase 3 PR #2, Task 3. Co-Authored-By: ruflo <ruv@ruv.net>
Replaces PR #99's synthetic-Finding placeholder pattern with a real async load through the existing useStorage().loadProject() chain. ProcessHubReviewPanel: - countFor derives chip count from ProcessHubInvestigationMetadata.findingCounts (same arithmetic as the previous synthetic-placeholder length) - loadFindingsForItem / onChipClick / onFindingSelect pass-through to Dashboard - removes the synthetic Finding[] cast and TODO(evidence-sheet-pr) comment - removes safeTrackEvent import (no longer needed in this component) Dashboard: - sheetState managed at Dashboard level (item + hubId + findings | null) - handleChipClick: fires telemetry, opens sheet in loading state, async-loads via loadProject() chain, applies findings with a race guard - handleFindingSelect: fires telemetry, closes sheet, navigates via existing onOpenProject + best-effort URL hash for finding deep-link - EvidenceSheet rendered at Dashboard level (sibling of StateItemNotesDrawer) Telemetry: process_hub.evidence_sheet_{opened,finding_clicked} with non-PII payloads (hubId from rollup.hub.id, lens, responsePath, findingStatus enum in finding-click event). No PII per ADR-059. Phase 3 PR #2, Task 4. Co-Authored-By: ruflo <ruv@ruv.net>
The guard `window.location.hash !== '#finding-${id}'` (with `#`) compared
against an assignment without `#` — the comparison was always false so
the guard never short-circuited. Assignment is idempotent in browsers
anyway; just drop the guard.
Phase 3 PR #2, code-review followup.
Co-Authored-By: ruflo <ruv@ruv.net>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…d telemetry
The Phase 3 spec's telemetry table specified payload {hubId, responsePath,
lens, evidenceCount} but the implementation omitted evidenceCount.
evidenceCount is the key engagement metric for the chip feature.
Threads count through the panel's onChipClick(item, hubId, count) so
Dashboard can include it in safeTrackEvent without re-deriving.
Phase 3 PR #2, code-review followup.
Co-Authored-By: ruflo <ruv@ruv.net>
jukka-matti
added a commit
that referenced
this pull request
May 4, 2026
…g) (#121) * docs: mark layered-process-view-v1 plan delivered V1 component, FrameView swaps (PWA + Azure), and doc updates (ADR-070, methodology.md, mental-model-hierarchy.md, llms.txt) all shipped via production-line-glance C2 (merged 2026-04-29). Plan frontmatter was never promoted; flipping deferred → delivered. Co-Authored-By: ruflo <ruv@ruv.net> * docs: consolidate product vision into one canonical spec Adds docs/superpowers/specs/2026-05-03-variscout-vision-design.md as the canonical product vision. Supersedes the 2026-04-27 operating-model and product-method-roadmap specs (moved to docs/archive/specs/ with status: superseded + forward pointer). methodology.md gets a forward-pointer banner and survives as longer-form companion. All inbound + outbound cross-refs updated; specs/index.md rows show status: Superseded. Vision thesis: "the map is the product" — Process Hub IS its logic map; one continuous canvas (DAG with branch + join + two-level nesting + context propagation) replaces the FRAME river-SIPOC + LayeredProcessView + LayeredProcessViewWithCapability stack; cards-with-mini-charts per step + drill-down panel + mode lenses replace the separate Analysis tab; "tributary" / "CTS" jargon retired. Engine and data model survive. 10 canvas commitments in spec section 3.3 are load-bearing. 11 open questions in section 8 carry brainstorm defaults that need explicit confirmation before implementation plans are written. Decision-log pinned under Replayed Decisions (2026-05-03). In-flight plan reconciliation (frontmatter status flips): - delivered: production-line-glance C1/C2/charts (PRs #105/#106/#107), actionable-current-process-state-panel (PR #98), phase-3 H1/H2 (PRs #100/#101/#102) - in-progress (corrected): coscout-intelligence-architecture, question-driven-eda-2-handoff, multi-level-scout-v1 - unchanged: phase-6-implementation-plan (deferred), investigation-wall (in-progress) Brainstorm transcript: ~/.claude/plans/i-would-like-to-composed-rose.md. Co-Authored-By: ruflo <ruv@ruv.net> * docs: lock vision §8 decisions; canvas replaces Frame+Analysis tabs Walk-through resolved 11 brainstorm-default markers in the 2026-05-03 vision spec §8, plus a new Q0 ("tab vs canvas scaffold") that emerged during journey mapping. Headlines: - Q0: Canvas eats Frame + Analysis tabs. Investigation / Improvement / Report keep their own surfaces. Wall is dual-home (destination + canvas overlay). JourneyPhase retires as a top-level nav primitive. - Q1: Drill-down is a modern floating overlay anchored to the clicked card with blurred-canvas backdrop (overrides spec's "side-panel slides from right" default — that conflicted with the locked C3 supersession of CoScout's right-rail claim). - Q5: No CoScout map drafting in V1; manual click/drag/connect canvas authoring is the path (overrides spec default). - Q7: Hard cutover, no migration window — no users yet to preserve. - Q8: PWA gets local Hub-of-one with IndexedDB persistence; Azure adds cloud sync + multi-Hub + cadence + CoScout + team features. - Q4 + Q11: Wall is dual-home; promoted hypotheses render as node markers, drafts as faint arrows. Vision spec: §3.4, §5.2, §5.3, §5.4, §5.6, §5.7, §6, §7, §8 rewritten in place; §8 replaced "open questions" with a "resolved decisions" table; frontmatter status promoted draft → accepted. ADR-070 (FRAME workspace): added 2026-05-03 supersession amendment explicitly retiring FRAME as a top-level route; lists what survives inside the Canvas vs what gets deleted in the same PR that ships it. Decision-log: appended 2026-05-03 entry summarizing all 12 decisions + pointer to the §8 walkthrough plan. Full rationale + spec/code follow-ups in ~/.claude/plans/lets-do-this-next-rustling-simon.md. Co-Authored-By: ruflo <ruv@ruv.net> * docs: §8 follow-ups — glossary, ADR amendments, roadmap re-tag Smaller doc follow-ups triggered by the 2026-05-03 vision §8 resolution (see commit f12e8b1 for the headline changes). - docs/glossary.md (Q10): canonicalized as the single home for VariScout terminology. New "Process methodology terms" section (step / sub-step / column / input / output / outcome / branch & join / Process Hub) and a "Retired terms" table (tributary → factor; CTS → outcome; FRAME workspace → Canvas; Analysis tab → Canvas + lenses; Layered Process View → Canvas with lenses; etc) with replacements + retirement reasons. - docs/01-vision/methodology.md (Q10): added forward pointer to glossary.md as the canonical terminology home; methodology stays as the longer narrative companion but stops re-defining terms. - ADR-068 (Q3): added 2026-05-03 amendment formalizing modes and levels as orthogonal axes. Modes = which lens; levels = which slice (canvas pan/zoom). Level inferred from canvas state, not a separate picker. Refines (does not replace) the 2026-04-28 level-aware coaching amendment. - ADR-059 (Q8): added 2026-05-03 amendment specifying PWA local Hub-of-one with IndexedDB persistence. Browser-tenant-only — Constitution P1 (browser-only processing) and P8 (no AI in free tier) preserved. Schema scope listed for the FRAME canvas detail spec to inherit. - product-method-roadmap-design.md (Q6): added explicit "this is sequencing, not destination" header. Status was already superseded; the new framing tells stakeholders to read the vision spec first and consult this doc only for delivery-order intent. docs:check green. No broken cross-refs, no orphans, frontmatter valid. Co-Authored-By: ruflo <ruv@ruv.net> * docs: add framing-layer design spec (Spec 1 of canvas-detail decomposition) First of five canvas-detail specs decomposed from the 2026-05-03 vision §8 walkthrough. Covers everything BEFORE canvas authoring proper — Hub creation, data ingestion, investigation entry, multi-source join, defect anchoring, Pareto integration, and the three composable canvas filter states. Two-layer model: - Hub-level (durable): process goal narrative + outcome measure(s) + specs + primary scope dimensions - Investigation-level (episodic): Issue → Question → CTP→CTQ Hypothesis → Evidence → Finding Mode B (first-time Hub creation): - Stage 1: free-text goal + scaffold chips (Purpose / Customer / What matters) - Stage 2: paste/upload (existing UX) - Stage 3: outcome confirmation with inline distribution + data quality + per-candidate inline specs (no σ-based suggestions — specs are customer-driven) + primary scope dimensions sub-step - Stage 5: investigation entry as floating modal with skip-path → observation-triggered EDA Mode A (reopening existing Hub): - A.1: reopen, no new data → straight to canvas - A.2-paste: match-summary card with timeline preview + 2-axis classifier (source × temporal); blocks on overlap and different-grain - A.2-evidence-source: background ingestion with "X new snapshots ↑" indicator (Azure only — PWA Hub-of-one has no cloud sync per Q8) Multi-source via shared keys: Hub spine = process line; multiple sources joined via lot_id / batch_id / part_id; per-source provenance; per-source independent timelines (V1). Defect data + Pareto: multi-anchor (per-step rejects + outcome); canvas-attached Pareto with two pickers (group-by × weighted-by); Y-axis adapts to active mode lens (count / cost / time / Cpk gap / %OOS / ...); Pareto-bar selection becomes canvas-wide scope filter with "Make this the investigation scope" promote-to-investigation. Three composable canvas filter states (time-window / scope / Pareto-grouped) compose declaratively without new aggregation primitives. ADR-073 holds: per-(node × context-tuple × scope) buckets stay heterogeneity-aware. Engine reuse: detectColumns() + inferMode() + validateData() + suggestNodeMappings + TimelineWindow + ParetoChart + StepErrorPareto + statusForCpk + investigation entities all already shipped. Almost no new infrastructure required. Spec is 638 lines, 16 sections including verification criteria. Indexed at docs/superpowers/specs/index.md. Inherits Q0 + Q1–Q11 anchors from §8 walkthrough at ~/.claude/plans/lets-do-this-next-rustling-simon.md. Sibling specs (deferred): Spec 2 manual canvas authoring, Spec 3 cards / drill-down / mode lenses, Spec 4 canvas overlays + Wall sync, Spec 5 IndexedDB persistence schema. Co-Authored-By: ruflo <ruv@ruv.net> * docs: revise Q8 — PWA persistence opt-in; .vrs files = shareable training scenarios Walking back the original Q8 wording ("PWA = local Hub-of-one with IndexedDB persistence" — auto-on) to Option 4 hybrid: session-only by default; opt-in via "Save to this browser" → IndexedDB-backed Hub-of-one; .vrs file export/import always available. Strategic reframe: PWA serves four personas (LSSGB students, demos, casual analysts, AND trainers authoring scenarios). Trainers package datasets + Hub state + sample investigations into a .vrs bundle and share via LMS / email; students import to start from a prepared training state. .vrs becomes the scenario-distribution format, positioning PWA as the methodology-teaching surface. Persistence is now explicit consent per persona — training students opt in once and auto-save; demo users skip; privacy-conscious users export to file; trainers export+share. Constitution P1 (browser-only processing) and P8 (no AI in free tier) preserved. Companies still use Azure tier for centralized + secure persistence per ADR-059. Updates: - vision spec §7 tier paragraph rewritten + §8 Q8 row updated - framing-layer spec §15 V1 scope adds opt-in Save-to-browser + .vrs export/import + IndexedDB-loaded-post-opt-in; §14 anchors table Q8 row revised - decision-log §1 entry added: "Q8 revised — PWA persistence opt-in" with strategic rationale (training scenarios; trainer persona; no surprise persistence on shared computers) - apps/pwa/CLAUDE.md hard rule updated from "no persistence" to "session-only by default; opt-in IndexedDB allowed; .vrs import/export for trainer-shared scenarios" docs:check green. Co-Authored-By: ruflo <ruv@ruv.net> * plan: Framing Layer V1 Slice 1 — Foundation (16 tasks, TDD bite-sized) First implementation plan from the framing-layer spec. Slice 1 scope (smallest end-to-end): - Mode B Stages 1–3 + canvas first paint (PWA + Azure) - Mode A.1 reopen (Azure always; PWA only if opted in) - PWA opt-in IndexedDB persistence (Q8-revised Option 4) - PWA .vrs file export/import (round-trip; trainer scenarios) - ProcessHub schema extension (processGoal, outcomes, primaryScopeDimensions) - Goal-context biased outcome detection - Multi-outcome validateData refactor - Inline per-candidate spec editor (no σ-based suggestions) - Characteristic-type-aware spec defaults - Primary scope dimensions auto-suggest + multi-select - Graceful degradation banner (no goal-keyword match) 16 tasks, TDD bite-sized (failing test → run + fail → implement → run + pass → commit). Task 0 locks 5 load-bearing decisions in a companion file. Subagent-driven default execution per feedback_subagent_driven_default; Sonnet workhorse. Out of scope (later slices): - Slice 2: Stage 5 modal + Mode A.2-paste + A.2-evidence-source - Slice 3: Multi-source via shared keys - Slice 4: Defect anchoring + Pareto on canvas Plan referenced from: - docs/decision-log.md §4 Session Backlog (queued row added) - docs/superpowers/specs/2026-05-03-framing-layer-design.md (Implementation plans section added — lists all 4 V1 slices) docs:check green; 471 docs frontmatter-valid. Co-Authored-By: ruflo <ruv@ruv.net> * plan: expand Tasks 6–15 to full TDD step-by-step Per writing-plans skill 'no placeholders' rule: each task in a plan must be self-contained because subagent-driven execution reads tasks out of order in fresh subagents per task. Original slice-1 plan had Tasks 1–5 fully step-by-step but Tasks 6–15 sketched ('follow the same TDD shape') — violated the rule. Expanded all 10 sketched tasks to the same TDD pattern as Tasks 1–5: failing test code → run + fail expected output → implementation code → run + pass expected output → commit message. Plan grew 1135 → 3272 lines. Tasks now self-contained: - 6: OutcomeCandidateRow (6 RTL tests) - 7: characteristicTypeDefaults (7 tests) - 8: suggestPrimaryDimensions + selector UI (9 tests) - 9: OutcomeNoMatchBanner (3 RTL tests) - 10: GoalBanner + OutcomePin (8 RTL tests) - 11: .vrs file format + export/import (5 tests) - 12: PWA Dexie hubRepository (7 tests) - 13: SaveToBrowserButton + VrsExport/Import (6 tests) - 14: PWA Mode B E2E + Mode A.1 RTL (3 tests) - 15: Azure HubCreationFlow + ProcessHubView GoalBanner (2 tests) Plan ready for superpowers:subagent-driven-development. docs:check green. Co-Authored-By: ruflo <ruv@ruv.net> * plan: lock 5 decisions for framing-layer V1 slice 1 D1: AnalysisBrief unchanged; new OutcomeSpec type D2: PWA persistence opt-in via 'Save to this browser' D3: validateData multi-outcome refactor D4: Goal-context biasing is deterministic keyword extraction D5: Mode A.1 reopen gated by IndexedDB opt-in flag (no PWA Hub list) * feat(core): add framing-layer fields to ProcessHub processGoal: string narrative (Hub-level durable) outcomes: OutcomeSpec[] (CTQs in plain language) primaryScopeDimensions: string[] (prominent picker dimensions) OutcomeSpec includes characteristicType (nominalIsBest / smallerIsBetter / largerIsBetter) — drives spec-input UI per framing-layer spec §5.3. Specs are customer-driven; no σ-based suggestions per Q8 / spec §3.3. * feat(core): extractHubName utility Extracts a short Hub name (≤50 chars, word-boundary truncated) from the first sentence of a goal narrative. Used by Stage 1 HubGoalForm to auto-populate the Hub name field on goal-narrative confirm. * fixup! feat(core): extractHubName utility Remove unnecessary .trimEnd() — plan's slice + lastIndexOf + final trim already handles the space-at-boundary case correctly without dropping an extra word. Co-Authored-By: ruflo <ruv@ruv.net> * feat(core): goal-context biasing in detectColumns Optional DetectColumnsOptions.goalContext threads the user's goal narrative through to outcome ranking. Tokenizes the narrative (lowercased, stopwords removed), computes per-column keyword overlap with the goal, adds a 0.5-weight bonus on top of existing scoring. Implements framing-layer spec §3.1: goal narrative biases deterministic detection at Stage 3. Deterministic — no AI (per Q5). Backward-compatible (option is optional). * feat(parser): refactor validateData to accept string[] outcomeColumns Signature changed from `(data, outcomeColumn: string | null)` to `(data, outcomeColumns: string[])`. A row is excluded when ANY listed outcome column is invalid. New `perOutcome: Record<string, PerOutcomeQuality>` field on DataQualityReport exposes per-column valid/invalid/missing counts. All six existing call sites updated; existing tests migrated to array API; no backward-compat overload (D3, feedback_no_backcompat_clean_architecture). Co-Authored-By: ruflo <ruv@ruv.net> * feat(ui): HubGoalForm component (framing layer Stage 1) Free-text textarea with three scaffold chips ('+ Purpose', '+ Customer', '+ What matters') that insert labeled prompt chunks into the narrative on click. Optional 'See examples' link surfaces three anonymized goal narratives. Skip-framing path supported. Implements framing-layer spec §5.1 — Option C 'free-text + scaffold chips' shape locked during brainstorm. * feat(ui): OutcomeCandidateRow with inline per-candidate specs Stage 3 horizontal candidate row layout: radio + name + sparkline + (when selected) inline spec inputs + quality stack + match confidence. LSL/USL placeholders say 'from customer spec' (no σ-based suggestions per Q8/Q2). LSL disabled for smallerIsBetter; USL disabled for largerIsBetter. Adds @variscout/core/processHub sub-path export so consumers can reach the new CharacteristicType / OutcomeSpec types without colliding with the unrelated CharacteristicType in core/types.ts. Implements framing-layer spec §5.3.1. Co-Authored-By: ruflo <ruv@ruv.net> * feat(core): characteristic-type-aware spec defaults inferOutcomeCharacteristicType: case-insensitive name-keyword detection (defect/reject/scrap/fail/error/fault → smallerIsBetter; yield/uptime/throughput/recovery/efficiency → largerIsBetter; default nominalIsBest). Renamed from the plan's inferCharacteristicType to avoid collision with the existing spec-limit-based inferCharacteristicType in core/types.ts. defaultSpecsFor: returns target=mean for nominalIsBest; target=0 for smallerIsBetter; no target for largerIsBetter. cpkTarget=1.33 (literature default) across the board. No LSL/USL suggestions — those are customer-driven (per Q8/Q2). 7 tests in packages/core/src/specs/__tests__/characteristicTypeDefaults.test.ts. Re-exported at root barrel as inferOutcomeCharacteristicType, defaultSpecsFor, DataStats. Co-Authored-By: ruflo <ruv@ruv.net> * feat: PrimaryScopeDimensions auto-suggest + selector UI suggestPrimaryDimensions filters columns by cardinality (3-50) + name keyword (id/lot/batch/product/customer/shift/operator/ machine/supplier/sku/plant/line/station). High-cardinality columns (>50 levels) flagged as 'join key, not Pareto candidate'. PrimaryScopeDimensionsSelector pre-checks suggested columns; user confirms or overrides; skippable. Implements framing- layer spec §3.4 and §5.3.2. Co-Authored-By: ruflo <ruv@ruv.net> * feat(ui): OutcomeNoMatchBanner graceful degradation Renders when max(candidate.matchScore) < 0.30 (cryptic columns or vague goal). Surfaces rename affordance, free-text 'I expected the outcome to be' note, and skip-outcome path. Hub records the user's pick for future detection (slice 1 stub; full learning loop in Spec 5). Implements framing-layer spec §5.3.3. * feat(ui): GoalBanner + OutcomePin canvas first-paint components GoalBanner renders Hub.processGoal at top of canvas; click-to-edit opens textarea with Save / Cancel; onChange callback to parent. Hides itself when goal is empty. OutcomePin shows Cpk badge when specs are set + n>=10; falls back to 'mean ± σ + n' + '+ Add specs' chip when specs absent; shows 'Trust pending' when specs set but n<10. Per Q2 fallback rule (framing-layer spec §5.2) and sample-size honesty (vision §2.3). * feat(core): .vrs file format + export/import (round-trip tested) VRS_VERSION='1.0'. VrsFile shape: version, exportedAt, hub, optional rawData, optional metadata (exportSource pwa|azure + appVersion). vrsExport(hub, rawData?, metadata?) → JSON string (pretty, indent 2). vrsImport(json) → VrsFile with version validation + clear error messages on mismatch. Hub-only export supported (rawData optional, useful for canvas-without-data sharing). Round-trip preserves Hub + rawData via JSON serialization. .vrs files double as shareable training scenarios per Q8-revised. Co-Authored-By: ruflo <ruv@ruv.net> * feat(pwa): Dexie hubRepository for opt-in Hub-of-one persistence New PwaDatabase (Dexie v1) with two tables: hubs (single-row Hub-of-one constraint) + meta (opt-in flag). hubRepository API: getOptInFlag / setOptInFlag (auto-clears Hub on false) / saveHub (overwrites single row) / loadHub (returns null if absent) / clearHub. Per Q8-revised: Dexie loaded only after explicit opt-in via 'Save to this browser' affordance (Task 13). Default behavior unchanged from today (session-only). dexie + fake-indexeddb added as dependencies. Co-Authored-By: ruflo <ruv@ruv.net> * feat(pwa): Save-to-browser opt-in + .vrs export/import buttons SaveToBrowserButton: shows 'Save to this browser' when not opted in; clicking opts in + persists Hub. Once opted in, auto-saves on Hub change. Button switches to 'Saved · Forget' — click + confirm clears persistence (calls setOptInFlag(false) which auto-clears Hub). VrsExportButton: serializes current Hub + data via vrsExport, downloads as <hub-name>.vrs (sanitized). VrsImportButton: file picker; reads file → vrsImport → emits onImport({ hub, rawData }) for parent to consume. Per Q8-revised hybrid persistence (Option 4). * feat(pwa): Mode A.1 reopen wiring + SessionProvider scaffold SessionProvider holds current Hub + rawData in React Context (in-memory; persistence via opt-in hubRepository). App.tsx: on mount, getOptInFlag → if true, loadHub() and seed sessionHub. GoalBanner renders above main content when sessionHub.processGoal is set, so a Mode A.1 reopen surfaces the saved Hub goal immediately. RTL test verifies both branches: opt-in false → HomeScreen; opt-in true + saved Hub → canvas with goal banner restored from IndexedDB. Mode B end-to-end (paste → goal → mapping → canvas first paint with OutcomePin per outcome) requires the ColumnMapping refactor that is out of scope for slice 1; the Playwright spec is checked in as .skip to be re-enabled when Stage 1/3 routing lands inside App.tsx. * feat(pwa): inject HubGoalForm Stage 1 into Mode B paste flow After paste analyze, before ColumnMapping, render HubGoalForm so the user states the process goal. On confirm, store narrative in sessionStore. On skip, sentinel '' marks the Stage 1 step done without a narrative. ColumnMapping now waits for goalNarrative !== null. ColumnMapping internals unchanged — Stage 3 refactor (using OutcomeCandidateRow / PrimaryScopeDimensionsSelector / OutcomeNoMatchBanner) ships in slice 2. Hub.processGoal is set at ColumnMapping confirm if narrative was provided; outcomes[] and primaryScopeDimensions are left for slice 2 (TODO marker in handleMappingConfirmWithGoal). Co-Authored-By: ruflo <ruv@ruv.net> * feat(azure): mount GoalBanner above Hub tabs + Dexie v7 no-op ProcessHubView renders <GoalBanner goal={hub.processGoal}> above the existing tab container — Mode A.1 reopen surfaces the saved process goal immediately on Hub load (Azure tier persists Hub-level state via Dexie always; no opt-in needed). Dexie schema bumped 6 -> 7 as a no-op version; the new ProcessHub fields (processGoal, outcomes, primaryScopeDimensions) added in Task 1 are optional TypeScript additions that Dexie stores without schema migration. (Plan said v4 -> v5; the actual Azure schema was already at v6, so the bump lands at v7.) GoalBanner is mounted read-only for slice 1 because ProcessHubView does not currently receive a Hub-update callback in its props; wiring onChange is deferred to slice 2 alongside HubCreationFlow. HubCreationFlow component (Stage 1 -> Stage 2 -> Stage 3 -> built Hub) and the Dashboard "+ New Hub" button are deferred to slice 2 — the plan's Stage3Mapping implementation is sketch-only and the full ColumnMapping refactor required to wire OutcomeCandidateRow / PrimaryScopeDimensionsSelector / OutcomeNoMatchBanner is out of scope for slice 1 (mirrors the slice-1 PWA Task 14 follow-up). Co-Authored-By: ruflo <ruv@ruv.net> * docs: framing-layer spec status draft -> active Spec is the active working design. Slice 1 implements its foundation; Stage 3 ColumnMapping refactor + multi-source + defect anchoring continue across slices 2-4. Decision-log session-backlog row already reflects in-flight status (commit d49cbfe). * docs: update slice-1 row with delivery state + slice-2 deferrals Slice 1 row → in-flight with the foundation enumeration and explicit slice-2 deferrals (Stage 3 ColumnMapping refactor, canvas first-paint OutcomePin, button mounting in PWA UI, Azure HubCreationFlow, Mode B E2E). Per final-reviewer finding (Important #2): Save-to-browser + .vrs Export/Import buttons are tested + scaffolded but currently unmounted — slice 2 will surface them in the PWA chrome. --------- Co-authored-by: ruflo <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the V2 evidence-chip half-loop. Today the chip count comes from
findingCountsmetadata (cheap), but click navigates blindly to the most-recent linked investigation. PR #2 makes the chip click open a bottom sheet listing the actual findings — labels, statuses, click-through to the specific finding inside the investigation.Building blocks:
ProcessHubEvidenceContractin@variscout/ui: split the synthetic-FindingfindingsForintocountFor(sync, derived from rollup metadata) +loadFindingsFor(async, called only on chip click) +onChipClick(item)(telemetry signal) +onFindingSelect(item, finding)(sheet selection callback). Eliminates theas unknown as readonly Finding[]cast from PR feat: ProcessHubCurrentStatePanel evidence chip (Phase 2 V2 PR #5) #99 and theTODO(evidence-sheet-pr)comment.EvidenceSheetcomponent in apps/azure (~90 LOC): bottom sheet with backdrop + Esc/click-outside/close-button →onClose. Loading state whenfindings === null; empty state whenfindings.length === 0; otherwise lists findings with label + status badge + click-thru.sheetState(item + hubId + findings | null);loadFindingsForItemasync-loads via paralleluseStorage().loadProject()calls + aggregates vialinkFindingsToStateItemsfrom core;handleChipClickopens sheet in loading state with race guard so rapid chip-toggle doesn't apply stale findings;handleFindingSelectnavigates via existingonOpenProject+ best-effort URL hash for finding deep-link.process_hub.evidence_sheet_opened(hubId,responsePath,lens) on chip click,process_hub.evidence_sheet_finding_clicked(hubId,lens,findingStatusenum) on finding select.Notable code-review fixes during execution
window.location.hash !== \#finding-${id}`(with#) against an assignment without#`; the guard never short-circuited. Dropped the guard since the assignment is idempotent.safeTrackEventlisted; opportunistically removed since it's a stable module-level import.Test plan
pnpm --filter @variscout/ui buildclean (cross-package type check)bash scripts/pr-ready-check.shgreenclaude --chromewalk: open Dashboard with hub that has analyzed findings, click chip → assert sheet opens with finding labels, click finding → assert URL navigates with#finding-{id}hashOut of scope (deferred)
#finding-{id}hash for scroll/highlight (separate ~50 LOC follow-up; the URL is set but the editor doesn't yet read it).analyzed/improving/resolved(already gated inlinkFindingsToStateItems).🤖 Generated with Claude Code