Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: fixed incorrect permission error returned; fix #5599 #5629

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

chenjie4255
Copy link
Contributor

The Winfsp expects a fuse error code returned, however, the juicefs return a syscall error code, leading almost all error codes being converted to the default error code "permission denied".

https://github.com/winfsp/winfsp/blob/4fdec4d37fb4e56b6d810714f5a201e275211aaf/src/dll/fuse/fuse.c#L1127

This Pr extends the original errorconv function, the changes are based on the error.i file from WinFSP.

https://github.com/winfsp/winfsp/blob/4fdec4d37fb4e56b6d810714f5a201e275211aaf/src/dll/fuse/errno.i#L1

meanwhile, this Pr adds an "access-log" mount option allowing the access log to be written into a file.

Test

  • git init
  • Set a small quota and copy a large file. the File Explorer can now correctly display the disk not enough message.
  • Mount with the "access-log" option, and confirm the logs are written.

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2025

CLA assistant check
All committers have signed the CLA.

@davies davies merged commit 08d5d82 into main Feb 10, 2025
35 checks passed
@davies davies deleted the fix_win_perm branch February 10, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants