Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta/redis: remove watch in doGetAttr and doGetFacl #5518

Merged
merged 2 commits into from
Jan 7, 2025
Merged

meta/redis: remove watch in doGetAttr and doGetFacl #5518

merged 2 commits into from
Jan 7, 2025

Conversation

jiefenghuang
Copy link
Contributor

No description provided.

@jiefenghuang jiefenghuang reopened this Jan 6, 2025
@jiefenghuang jiefenghuang changed the title meta/redis: remove watch in doGetAttr meta: remove watch and txn in doGetAttr Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (d329bb0) to head (61fed9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5518      +/-   ##
==========================================
+ Coverage   54.50%   60.96%   +6.46%     
==========================================
  Files         165       29     -136     
  Lines       47877    19679   -28198     
==========================================
- Hits        26094    11998   -14096     
+ Misses      18936     6106   -12830     
+ Partials     2847     1575    -1272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anysql
Copy link
Contributor

anysql commented Jan 6, 2025

The new logic removed the retry for some failures.

So does for doRead and doGetParents, while the sql engine has the retry logic.

@jiefenghuang jiefenghuang changed the title meta: remove watch and txn in doGetAttr meta/redis: remove watch in doGetAttr Jan 7, 2025
@jiefenghuang
Copy link
Contributor Author

The new logic removed the retry for some failures.

So does for doRead and doGetParents, while the sql engine has the retry logic.

This is unrelated to the modification. Additionally, the Redis client will retry for common failures.

@jiefenghuang jiefenghuang marked this pull request as draft January 7, 2025 02:44
@jiefenghuang jiefenghuang changed the title meta/redis: remove watch in doGetAttr meta/redis: remove watch in doGetAttr and doGetFacl Jan 7, 2025
Signed-off-by: jiefenghuang <[email protected]>
@jiefenghuang jiefenghuang marked this pull request as ready for review January 7, 2025 03:38
@davies davies merged commit 3f7f080 into main Jan 7, 2025
35 checks passed
@davies davies deleted the fix-redis branch January 7, 2025 06:38
@zhoucheng361 zhoucheng361 added missed missed bug priority/high The highest priority regression regression issue module/meta labels Jan 7, 2025
jiefenghuang added a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.2 missed missed bug module/meta priority/high The highest priority regression regression issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants