Fix warning log when creating a new cache dir #5200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Changxin Miao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5200 +/- ##
===========================================
- Coverage 54.27% 43.94% -10.33%
===========================================
Files 161 104 -57
Lines 43776 19341 -24435
===========================================
- Hits 23758 8500 -15258
+ Misses 17336 10066 -7270
+ Partials 2682 775 -1907
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jiefenghuang
approved these changes
Sep 29, 2024
|
we should ignore the EEXISTS from Mkdir, it's an expected behavior |
Signed-off-by: jiefenghuang <[email protected]>
jiefenghuang
force-pushed
the
mkdir-warning
branch
from
f102a71 to
89fcbd9
Compare
|
We have os.Stat check in the beginning, and only create if os.Stat says it doesn't exist. So I suppose the EEXISTS error is a unexpected behavior? |
|
It's expected that more than one goroutine will call createDir(), so one fail with EEXISTS is expected. |
|
OK, get it - it has concurrent access when writing caches. |
Signed-off-by: Changxin Miao <[email protected]>
jiefenghuang
added a commit
that referenced
this pull request
Nov 26, 2024
Signed-off-by: Changxin Miao <[email protected]> Signed-off-by: jiefenghuang <[email protected]> Co-authored-by: jiefenghuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to the latest master branch, a lot of warning logs show up (see attached screenshot).
This happens because
diris appended with "/" in the CacheManager (I don't know why), and when callingfilepath.Diron a string ending with "/", the function returns the same dir (with "/" trimed). So same dir is passed toos.Mkdirtwice, and the second call will raise a warning log. This may cause confusion to users.