warmup: evict sub command may remove stage incorrectly #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiefenghuang <[email protected]>
jiefenghuang
changed the title
davies
reviewed
Aug 22, 2024
pkg/chunk/disk_cache.go
Outdated
| @@ -1005,6 +1025,7 @@ func expandDir(pattern string) []string { | |||
| type CacheManager interface { | |||
| cache(key string, p *Page, force, dropCache bool) | |||
| remove(key string) | |||
| removeReadCache(key string) // remove read cache only | |||
There was a problem hiding this comment.
it's better to add a flag in remove(key)
davies
changed the title
|
Kind reminder - when file is not uploaded to S3, it's dangerous to delete it from cache folder, especially when user enabled I suggest the evict subcommand should just ignore staging files. |
Signed-off-by: jiefenghuang <[email protected]>
zhijian-pro
approved these changes
Aug 23, 2024
SandyXSD
pushed a commit
that referenced
this pull request
Aug 27, 2024
Signed-off-by: jiefenghuang <[email protected]> Co-authored-by: Davies Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new interface to clear the read cache.