Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: skip init meta bucket when meta is read only #4992

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Jul 8, 2024

  1. Resolve a compatibility issue where the 1.2 version of gateway could not create a configuration file directory in the case of meta-readonly.
  2. Fixed the bug that deleting an object through a web page does not report an error when using meta read-only.

close #4975
close #4989
close #4988

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 15.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 54.58%. Comparing base (a8cb0fc) to head (61a3a4e).
Report is 25 commits behind head on main.

Files Patch % Lines
pkg/gateway/gateway.go 15.38% 6 Missing and 5 partials ⚠️
cmd/gateway.go 14.28% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4992       +/-   ##
===========================================
+ Coverage   24.97%   54.58%   +29.60%     
===========================================
  Files          25      161      +136     
  Lines       16045    43570    +27525     
===========================================
+ Hits         4007    23782    +19775     
- Misses      11549    17095     +5546     
- Partials      489     2693     +2204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jiefenghuang jiefenghuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiefenghuang jiefenghuang merged commit 61a0099 into main Jul 19, 2024
39 checks passed
@jiefenghuang jiefenghuang deleted the gateway-readonly-v2 branch July 19, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants